Pin rust toolchain to 1.90 #523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 07ec4d7 | Previous: ea5dc7a | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2263842472 ns/iter (± 12710034) |
2254218250 ns/iter (± 9092623) |
1.00 |
rule-match-first-request/brave-list |
1056702 ns/iter (± 13627) |
1040226 ns/iter (± 7997) |
1.02 |
blocker_new/brave-list |
154206140 ns/iter (± 1643597) |
155889016 ns/iter (± 929089) |
0.99 |
blocker_new/brave-list-deserialize |
67129709 ns/iter (± 1083092) |
68301030 ns/iter (± 841217) |
0.98 |
memory-usage/brave-list-initial |
18344519 ns/iter (± 3) |
18344519 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
66961309 ns/iter (± 3) |
66961309 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1616130 ns/iter (± 3) |
1616130 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests |
2551938 ns/iter (± 3) |
2551938 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests/alloc-count |
68864 ns/iter (± 3) |
68864 ns/iter (± 3) |
1 |
url_cosmetic_resources/brave-list |
206156 ns/iter (± 2374) |
206048 ns/iter (± 1753) |
1.00 |
cosmetic-class-id-match/brave-list |
4298312 ns/iter (± 1157888) |
4279031 ns/iter (± 1162303) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
mschfh
approved these changes
Sep 29, 2025
antonok-edm
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust toolchain should be updated by a PR (in a combination with fixing new errors/linter issues)
Tested with 1.89 pinned on a custom branch:
