Add removeparam filters to the serialized data format #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: f90057e | Previous: ea5dc7a | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2150805622 ns/iter (± 8645768) |
2254218250 ns/iter (± 9092623) |
0.95 |
rule-match-first-request/brave-list |
1071008 ns/iter (± 7613) |
1040226 ns/iter (± 7997) |
1.03 |
blocker_new/brave-list |
161689836 ns/iter (± 1571020) |
155889016 ns/iter (± 929089) |
1.04 |
blocker_new/brave-list-deserialize |
63750086 ns/iter (± 1284435) |
68301030 ns/iter (± 841217) |
0.93 |
memory-usage/brave-list-initial |
18344503 ns/iter (± 3) |
18344519 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/max |
66961277 ns/iter (± 3) |
66961309 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/alloc-count |
1616082 ns/iter (± 3) |
1616130 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2551890 ns/iter (± 3) |
2551938 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
68816 ns/iter (± 3) |
68864 ns/iter (± 3) |
1.00 |
url_cosmetic_resources/brave-list |
189075 ns/iter (± 1388) |
206048 ns/iter (± 1753) |
0.92 |
cosmetic-class-id-match/brave-list |
5119900 ns/iter (± 1511311) |
4279031 ns/iter (± 1162303) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
ShivanKaul
approved these changes
Sep 29, 2025
antonok-edm
force-pushed
the
include-removeparam-in-data-format
branch
from
bb28004 to
f90057e
Compare
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: f90057e | Previous: ea5dc7a | Ratio |
|---|---|---|---|
cosmetic-class-id-match/brave-list |
5119900 ns/iter (± 1511311) |
4279031 ns/iter (± 1162303) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #524
(This is already fixed in the 0.11.x branch; this is just a fix for the 0.10.x series)