Fix clippy issues for 0.11.x #529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonok-edm
approved these changes
Oct 14, 2025
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 8475c24 | Previous: 1bfadd6 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2273913912 ns/iter (± 15679771) |
2157327098 ns/iter (± 15833464) |
1.05 |
rule-match-first-request/brave-list |
1138805 ns/iter (± 23579) |
1067208 ns/iter (± 8765) |
1.07 |
blocker_new/brave-list |
148605817 ns/iter (± 1288095) |
175128732 ns/iter (± 2762769) |
0.85 |
blocker_new/brave-list-deserialize |
21119089 ns/iter (± 611989) |
73769476 ns/iter (± 854420) |
0.29 |
memory-usage/brave-list-initial |
10072443 ns/iter (± 3) |
18344503 ns/iter (± 3) |
0.55 |
memory-usage/brave-list-initial/max |
64817658 ns/iter (± 3) |
66961277 ns/iter (± 3) |
0.97 |
memory-usage/brave-list-initial/alloc-count |
1534721 ns/iter (± 3) |
1616082 ns/iter (± 3) |
0.95 |
memory-usage/brave-list-1000-requests |
2516487 ns/iter (± 3) |
2551890 ns/iter (± 3) |
0.99 |
memory-usage/brave-list-1000-requests/alloc-count |
66641 ns/iter (± 3) |
68816 ns/iter (± 3) |
0.97 |
url_cosmetic_resources/brave-list |
203791 ns/iter (± 1051) |
189708 ns/iter (± 2713) |
1.07 |
cosmetic-class-id-match/brave-list |
15761561 ns/iter (± 4827113) |
5166097 ns/iter (± 1523809) |
3.05 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rust Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.10.
| Benchmark suite | Current: 8475c24 | Previous: 1bfadd6 | Ratio |
|---|---|---|---|
cosmetic-class-id-match/brave-list |
15761561 ns/iter (± 4827113) |
5166097 ns/iter (± 1523809) |
3.05 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.