Enable cosmetic filters in some benches #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 1cf2f31 | Previous: 89c89f1 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2222257314 ns/iter (± 15077396) |
2281785008 ns/iter (± 19472197) |
0.97 |
rule-match-first-request/brave-list |
1128428 ns/iter (± 17647) |
1158543 ns/iter (± 9447) |
0.97 |
blocker_new/brave-list |
174637984 ns/iter (± 1306047) |
160762406 ns/iter (± 2163002) |
1.09 |
blocker_new/brave-list-deserialize |
22885417 ns/iter (± 60373) |
23304469 ns/iter (± 553759) |
0.98 |
memory-usage/brave-list-initial |
11499344 ns/iter (± 3) |
11499344 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
67489131 ns/iter (± 3) |
67489115 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/alloc-count |
1660509 ns/iter (± 3) |
1660477 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests |
2666958 ns/iter (± 3) |
2666926 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
71369 ns/iter (± 3) |
71337 ns/iter (± 3) |
1.00 |
url_cosmetic_resources/brave-list |
200169 ns/iter (± 790) |
197743 ns/iter (± 2029) |
1.01 |
cosmetic-class-id-match/brave-list |
3358237 ns/iter (± 906470) |
3339425 ns/iter (± 965578) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
boocmp
approved these changes
Oct 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For brave/brave-browser#50463
For my machine this updates
bench_rules/blocker_new/brave-listfrom159.18 msto more realistic186.04 ms.Although, for CI is only +9%