Optimize vec[] creation #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atuchin-m
force-pushed
the
optimize-utils-tokenize
branch
from
e47f1f9 to
01af219
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: 01af219 | Previous: 671ee95 | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
2250322959 ns/iter (± 18342022) |
2291947688 ns/iter (± 10780439) |
0.98 |
rule-match-first-request/brave-list |
1095665 ns/iter (± 12657) |
1098909 ns/iter (± 9107) |
1.00 |
blocker_new/brave-list |
173913464 ns/iter (± 1163989) |
178639073 ns/iter (± 674433) |
0.97 |
blocker_new/brave-list-deserialize |
24288757 ns/iter (± 399811) |
24510742 ns/iter (± 406712) |
0.99 |
memory-usage/brave-list-initial |
10212224 ns/iter (± 3) |
10212224 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
64056423 ns/iter (± 3) |
64057431 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-initial/alloc-count |
1482122 ns/iter (± 3) |
1610823 ns/iter (± 3) |
0.92 |
memory-usage/brave-list-1000-requests |
2666958 ns/iter (± 3) |
2666926 ns/iter (± 3) |
1.00 |
memory-usage/brave-list-1000-requests/alloc-count |
71369 ns/iter (± 3) |
71337 ns/iter (± 3) |
1.00 |
url_cosmetic_resources/brave-list |
206558 ns/iter (± 824) |
198077 ns/iter (± 983) |
1.04 |
cosmetic-class-id-match/brave-list |
3342175 ns/iter (± 931503) |
3358839 ns/iter (± 920606) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
antonok-edm
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For brave/brave-browser#50463
The PR improves ruleset building time by reducing the number of allocations (
-8%, seememory-usage/brave-list-initial/alloc-count)