Fix no hostname case #562
Merged
Fix no hostname case #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Rust Benchmark
| Benchmark suite | Current: cd3df6a | Previous: 2e8522e | Ratio |
|---|---|---|---|
rule-match-browserlike/brave-list |
1952435059 ns/iter (± 6995158) |
2018318447 ns/iter (± 21765134) |
0.97 |
rule-match-first-request/brave-list |
1086932 ns/iter (± 10810) |
1125936 ns/iter (± 7201) |
0.97 |
blocker_new/brave-list |
151067384 ns/iter (± 1023001) |
152949922 ns/iter (± 796277) |
0.99 |
blocker_new/brave-list-deserialize |
26575134 ns/iter (± 153793) |
26230664 ns/iter (± 2358387) |
1.01 |
memory-usage/brave-list-initial |
10212216 ns/iter (± 3) |
10212216 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/max |
63149135 ns/iter (± 3) |
63149135 ns/iter (± 3) |
1 |
memory-usage/brave-list-initial/alloc-count |
1231721 ns/iter (± 3) |
1231721 ns/iter (± 3) |
1 |
memory-usage/brave-list-1000-requests |
2645938 ns/iter (± 3) |
2666990 ns/iter (± 3) |
0.99 |
memory-usage/brave-list-1000-requests/alloc-count |
71016 ns/iter (± 3) |
71425 ns/iter (± 3) |
0.99 |
url_cosmetic_resources/brave-list |
190034 ns/iter (± 767) |
189892 ns/iter (± 986) |
1.00 |
cosmetic-class-id-match/brave-list |
3560017 ns/iter (± 1023323) |
3396414 ns/iter (± 922069) |
1.05 |
This comment was automatically generated by workflow using github-action-benchmark.
boocmp
approved these changes
Nov 12, 2025
antonok-edm
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR addresses matching issues that makes the behavior unstable: the result depends on the order we checked the tokens.