Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

site menu is missing links to cert, cookie manager, and site settings #10009

Closed
rebron opened this issue May 29, 2020 · 3 comments · Fixed by brave/brave-core#5707
Closed

site menu is missing links to cert, cookie manager, and site settings #10009

rebron opened this issue May 29, 2020 · 3 comments · Fixed by brave/brave-core#5707
Assignees
@mkarolin
Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Milestone
1.10.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented May 29, 2020

Description

Site menu should still have links to cert, cookie manager, and site settings instead of being replaced with a listing of site settings (somewhat convenient but not implemented in the proper way).

Steps to Reproduce

  1. Visit any url.
  2. Select lock icon to pull up the menu.
  3. Notice links to cert and cookie manager are missing.

Actual result:

Screen Shot 2020-05-28 at 11 43 07 PM

Expected result:

Screen Shot 2020-05-29 at 12 58 42 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

Brave 1.11.37 Chromium: 83.0.4103.61 (Official Build) nightly (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.15.5 (Build 19F83c)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No.
  • Can you reproduce this issue with the beta channel? No.
  • Can you reproduce this issue with the dev channel? No.
  • Can you reproduce this issue with the nightly channel? Yes.

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

Chromium 83 clean-up.
@rebron rebron added bug feature/global-settings Settings at browser level independent of shields settings regression OS/Desktop QA/Yes labels May 29, 2020
@rebron
Copy link
Collaborator Author

rebron commented May 29, 2020

cc: @mkarolin can you take a look when you get a chance?

mkarolin added a commit to brave/brave-core that referenced this issue Jun 2, 2020
@mkarolin
Fixes page info bubble content.
390f9b3 
Fixes brave/brave-browser#10009

Fixes a regression where site settings would be shown in the page info
bubble when they shouldn't be.

The override was adding settings to the list instead of only not adding
the ones we care about.
@mkarolin mkarolin mentioned this issue Jun 2, 2020
Merged
32 tasks
@mkarolin mkarolin self-assigned this Jun 2, 2020
@mkarolin mkarolin mentioned this issue Jun 2, 2020
Merged
32 tasks
bsclifton pushed a commit to brave/brave-core that referenced this issue Jun 3, 2020
@mkarolin @bsclifton
Fixes page info bubble content.
c1dcf5a 
Fixes brave/brave-browser#10009

Fixes a regression where site settings would be shown in the page info
bubble when they shouldn't be.

The override was adding settings to the list instead of only not adding
the ones we care about.
@bsclifton bsclifton added this to the 1.11.x - Nightly milestone Jun 3, 2020
@mkarolin mkarolin mentioned this issue Jun 4, 2020
Merged
32 tasks
@rebron
Copy link
Collaborator Author

rebron commented Jun 9, 2020

Verified fix using:

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.15.5 (Build 19F83c)

Screen Shot 2020-06-09 at 10 32 08 AM

@kjozwiak
Copy link
Member

kjozwiak commented Jun 11, 2020 •
edited by btlechowski
Loading

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)
  • ensured that clicking on Certificate correctly loads the certificate viewer
    • ensured that you can go through the various levels of the certificate
  • ensured that clicking on Cookies opens the Cookies in use viewer
    • ensured that you can view/browse through the various cookies listed
    • ensured that you can remove various cookies using Remove
    • ensured that you can Block & Unblock cookies
    • ensured that Clear on exit works as expected
  • ensured that clicking on Site settings opens brave://settings/content/siteDetails?site=[website] without issues/crashes

Screen Shot 2020-06-10 at 11 05 15 PM

Screen Shot 2020-06-10 at 11 09 37 PM

Verification passed on


Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that clicking on Certificate correctly loads the certificate viewer
    • ensured that you can go through the various levels of the certificate
  • ensured that clicking on Cookies opens the Cookies in use viewer
    • ensured that you can view/browse through the various cookies listed
    • ensured that you can remove various cookies using Remove
    • ensured that you can Block & Unblock cookies
    • ensured that Clear on exit works as expected
  • ensured that clicking on Site settings opens brave://settings/content/siteDetails?site=[website] without issues/crashes

image
image

Verification passed on

Brave 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
Revision 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS Ubuntu 18.04 LTS
  • ensured that clicking on Certificate correctly loads the certificate viewer
    • ensured that you can go through the various levels of the certificate
  • ensured that clicking on Cookies opens the Cookies in use viewer
    • ensured that you can view/browse through the various cookies listed
    • ensured that you can remove various cookies using Remove
    • ensured that you can Block & Unblock cookies
    • ensured that Clear on exit works as expected
  • ensured that clicking on Site settings opens brave://settings/content/siteDetails?site=[website] without issues/crashes

image
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
bug feature/global-settings Settings at browser level independent of shields settings OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.10.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes page info bubble content. brave/brave-core
6 participants
@kjozwiak @bsclifton @rebron @btlechowski @GeetaSarvadnya @mkarolin