-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
site menu is missing links to cert, cookie manager, and site settings #10009
Labels
bug
feature/global-settings
Settings at browser level independent of shields settings
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
regression
release-notes/exclude
Milestone
Comments
rebron
added
bug
feature/global-settings
Settings at browser level independent of shields settings
regression
OS/Desktop
QA/Yes
labels
May 29, 2020
cc: @mkarolin can you take a look when you get a chance? |
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Jun 2, 2020
Fixes brave/brave-browser#10009 Fixes a regression where site settings would be shown in the page info bubble when they shouldn't be. The override was adding settings to the list instead of only not adding the ones we care about.
32 tasks
32 tasks
bsclifton
pushed a commit
to brave/brave-core
that referenced
this issue
Jun 3, 2020
Fixes brave/brave-browser#10009 Fixes a regression where site settings would be shown in the page info bubble when they shouldn't be. The override was adding settings to the list instead of only not adding the ones we care about.
32 tasks
Verified fix using:
|
Verification PASSED on
Verification passed on
Verification passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
feature/global-settings
Settings at browser level independent of shields settings
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
regression
release-notes/exclude
Description
Site menu should still have links to cert, cookie manager, and site settings instead of being replaced with a listing of site settings (somewhat convenient but not implemented in the proper way).
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
Easily.
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
Chromium 83 clean-up.
The text was updated successfully, but these errors were encountered: