Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Note: text is displayed twice in the cross custodial tipping notice #29081

Closed
GeetaSarvadnya opened this issue Mar 15, 2023 · 2 comments · Fixed by brave/brave-core#17808
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@GeetaSarvadnya
Copy link

Description

Found while testing #27255
Note: text is displayed twice in the cross custodial tipping notice

Steps to reproduce

  1. Follow the steps 1 to 4 from [Android] Follow up of #27255 - Cross custodial tipping notice text is not updated in BR panel and tipping banner #29080 (comment)
  2. Open the tipping banner for http://github.com/miyayes or alexvincentmusic.com
  3. Note: text is displayed twice in the cross custodial tipping notice

Actual result

Note: text is displayed twice in the cross custodial tipping notice
image

Expected result

Note: text should be displyed once although the remaining message is not correct which will be taken care in #29080

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): All
  • Device type (Phone, Tablet, Phablet): Vivo X70 Pro
  • Android version: 12

Brave version

1.50.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @sujitacharya2005 @deeppandya @Miyayes

@kjozwiak
Copy link
Member

The above requires 1.50.121 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link
Author

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.50.121

Gemini pubs Bitflyer pubs
Screenshot_20230419_180649 Screenshot_20230419_180717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants