Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Follow up of #27255 - Cross custodial tipping notice text is not updated in BR panel and tipping banner #29080

Closed
GeetaSarvadnya opened this issue Mar 15, 2023 · 2 comments · Fixed by brave/brave-core#17808
Assignees
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 15, 2023

Description

Found while testing #27255

Follow up of #27255 - Cross custodial tipping notice text is not updated in BR panel and tipping banner

Steps to reproduce

  1. Clean profile 1.50.90
  2. Connect Uphold custodian
  3. Follow the test plan from Changes cross-custodial tipping notice text (+ minor refactor around PublisherStatus). brave-core#16323 (comment)
  4. Open http://github.com/miyayes (pub verified with Gemini) or alexvincentmusic.com (pubs verified with bitFlyer)
  5. Cross custodial tipping notice text is not updated in BR panel and tipping banner for the above pubs

Actual result

Cross custodial tipping notice text is not updated in BR panel and tipping banner

BR panel Tipping banner
image image

Expected result

When Uphold KYC'd wallet is used with Rewards, the text on the panel and tipping banner is NOT updated when attempting to tip Gemini and bitFlyer verified creators.

Desktop

panel tipping banner
image image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Vivo X70 Pro
  • Android version: 12

Brave version

1.50.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/qa-team @deeppandya @sujitacharya2005 @Miyayes

@kjozwiak
Copy link
Member

The above requires 1.50.121 or higher for 1.50.x verification 👍

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 19, 2023

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.50.121

Cross custodian pubs https://github.com/miyayes

BR panel Tipping Banner
Screenshot_20230419_180644 Screenshot_20230419_180649

Cross custodian pubs https://alexvincentmusic.com

BR panel Tipping Banner
Screenshot_20230419_180712 Screenshot_20230419_180717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants