Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Enable in app update dialog < android 14 #38394

Closed
deeppandya opened this issue May 17, 2024 · 3 comments · Fixed by brave/brave-core#23727
Closed

[Android] Enable in app update dialog < android 14 #38394

deeppandya opened this issue May 17, 2024 · 3 comments · Fixed by brave/brave-core#23727
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/updater OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@deeppandya
Copy link

As a follow up to #38034, we need to enable in app update dialog for < android 14 devices.

@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024

The above requires 1.67.109 or higher for 1.67.x verification 👍

@kjozwiak
Copy link
Member

kjozwiak commented Jun 7, 2024

@hffvld @Uni-verse can use brave/brave-core#23727 (comment) as a general template. Some info to keep in mind when running through the above:

  • the GPS modal will appear once a month
  • the Update toast at the bottom of the page will appear once per sessions once the update is ready/staged
  • keep in mind if you move too ahead, sometimes updates won't work due to the device being ahead in time
    • certain websites will also stop working due to the device being to ahead

While we're running through the above, we should also verify that updating with the above way doesn't cause any issues re: losing state. Please run through an upgrade like we usually do but running through the above method.

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 12, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 12, 2024

Verified on Pixel 2 XL and Galaxy A32 5G using version(s):

Device/OS: 
- Pixel 2 XL / taimen-user  8.1.0 OPM2.171026.006.H1 release-keys
- Galaxy A32 5G / a32xsq-user 13 TP1A.220624.014 release-keys
Brave build: 1.67.112
Chromium: 126.0.6478.40 (Official Build) (32-bit) 

STEPS:

  1. Follow the STR/TP from Enable in app update dialog for < android 14 devices brave-core#23727 (comment)
  2. Verify
Test Case 1 - Basic Update/Dismissing toast several times (functionality check)

ACTUAL RESULTS:

  • Verified that there's no GPS bottom-sheet modal re: requiring an update when Brave 1.67.112 is installed and 1.67.113 is available for the upgrade if the system time is set to: today's date/one week from today/two weeks from today /three weeks from today/four weeks from today.
  • Verified that GPS bottom-sheet modal re: requiring an update is shown when Brave 1.67.112 is installed and 1.67.113 is available for the upgrade if the system time is set to one month from today's date.
  • Verified that tapping on Learn more opens the Brave Browser page via the GPS.
  • Verified that tapping on Update eventually shows an Update toast message at the bottom of the current Brave's tab/page.
  • Verified that the Update toast message which appears at the bottom of the page is dismissed after a few seconds
  • Verified that the Update toast message appears anytime you restart Brave after you tapped Update in the original bottom-sheet GPS modal
  • Verified that the Update toast message doesn't appear again for the same Brave session
  • Verified that tapping on Update installs/relaunches Brave without any issues

Pixel 2 XL / Android 8.1

1 2 3
1 2 3
1 2 3

Galaxy A32 5G / Android 13

1 2 3 4
1 2 3 4
1 2 3 4
Test Case 2 - Dismissing GPS Modal

ACTUAL RESULTS:

  • Verified that there's no GPS bottom-sheet modal re: requiring an update when Brave 1.67.112 is installed and 1.67.113 is available for the upgrade if the system time is set to: today's date/one week from today/two weeks from today /three weeks from today.
  • Verified that once you're a month ahead, the GPS bottom-sheet modal which indicates there's a new update via the GPS is shown
  • Verified that tapping X dismisses the GPS bottom-sheet modal
  • Verified that you don't see the GPS bottom-sheet modal after restarting Brave several times (will be displayed in another month)
  • Verified that the GPS bottom-sheet modal is shown again after another month pass

Pixel 2 XL / Android 8.1

2024-06-12_14-51-34.mp4

Galaxy A32 5G / Android 13

2024-06-12_16-18-40.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/updater OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android 8+ QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants