Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable in app update dialog for < android 14 devices (uplift to 1.67.x) #23809

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Enable in app update dialog for < android 14 devices (uplift to 1.67.x) #23809

merged 1 commit into from
Jun 7, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 23, 2024 •
edited by kjozwiak

Uplift of #23727
Resolves brave/brave-browser#38394

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team May 23, 2024 13:54
@brave-builds brave-builds requested a review from a team as a code owner May 23, 2024 13:54
@brave-builds brave-builds added this to the 1.67.x - Beta milestone May 23, 2024
@brave-builds brave-builds self-assigned this May 23, 2024
kjozwiak
kjozwiak approved these changes Jun 7, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.67.x approved 👍 QA has verified the PR on Nightly using 1.68.x as per #23727 (comment).

@kjozwiak kjozwiak merged commit 0161336 into 1.67.x Jun 7, 2024
15 checks passed
@kjozwiak kjozwiak deleted the pr23727_in_app_update_android_13_and_below_1.67.x branch June 7, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.67.x - Release
2 participants
@brave-builds @kjozwiak