-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable in app update dialog for < android 14 devices #23727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
95a92c5
to
2d2d8a6
Compare
2d2d8a6
to
cb56a5b
Compare
|
Example |
Example |
Example |
---|---|---|
Toast/Installing`
Example |
Example |
---|---|
Test Case #2
- Dismissing GPS Modal
- install/launch
1.68.41 Chromium 125.0.6422.76
and ensure there's no GPS modal re: requiring an update - close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
- close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
- close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
- close Brave and move system clock ahead ~a week (should be a month ahead)
- once you're a month ahead, ensure that you receive a GPS modal that indicates there's a new update via the GPS
- dismiss the GPS modal by pressing on
X
- ensure that you don't see the GPS modal after restarting Brave several times (will be displayed in another month)
- close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
- close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
- close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
- once you're a another month ahead, ensure that you receive a GPS modal that indicates there's a new update via the GPS
Screen_Recording_20240810_015454_Settings.mp4
Android 14
verification
Verification PASSED on Pixel 6
running Android 14
using the following build(s):
Brave | 1.68.41 Chromium: 125.0.6422.76 (Official Build) canary (64-bit)
--- | ---
Revision | f788cc73b5c571ea196bd6d4495cad0c3e81bf08
OS | Android 14; Build/AP21.240305.006; 34; REL
- install/launch
1.68.41 Chromium 125.0.6422.76
and ensure there's no GPS modal re: requiring an update - close Brave and move system clock ahead 1 week and ensure there's GPS modal re: requiring an update
- close Brave and move system clock ahead 1 week (two weeks ahead) and ensure there's GPS modal re: requiring update
- close Brave and move system clock ahead 1 week (three weeks ahead) and ensure there's GPS modal re: requiring update
- close Brave and move system clock ahead ~a week (should be a month ahead)
- ensured that the GPS modal doesn't appear on
Android 14
devices
Example --> https://youtu.be/EKtFRnBK9sE
Resolves brave/brave-browser#38394
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Please reach out to @deeppandya more details.