Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support of custom PGO profiles #39609

Open
atuchin-m opened this issue Jul 8, 2024 · 3 comments · May be fixed by brave/brave-core#26503
Open

Implement support of custom PGO profiles #39609

atuchin-m opened this issue Jul 8, 2024 · 3 comments · May be fixed by brave/brave-core#26503
Assignees

Comments

@atuchin-m
Copy link
Contributor

Description

The plan:
Stage 1. Make a custom win-x64 build to estimate profit, prepare minispec.
Stage 2. Make npm run perf_test -- --generate_pgo_profiles to generate and upload the profiles. Support fetching the profiles for official buids. Devops task: https://github.com/brave/devops/issues/11983
Stage 3. Establish CI to update profiles for master once a week (win-x64)
Stage 4. Extend this to beta and stable
Stage 5. Suppose some other configs taking into account the maintenance costs (consider supporing android-arm64 and mac-m1)

Some points:

  • Profile generation it should be done automatically, via a CI job. Running the perf tests becomes critical to the release process. We have to add smoke tests to cover them.
  • Each branch (nightly, beta, stable) has a separate profiles.
  • We have to run the perf test for beta& stable from time to time to be sure that PGO profiles are fine.
  • We don't have to use calibrate machines to generate profiles, AWS nodes could be used.
  • To generate PGO profiles, Chrome uses a set of benchmarks, one of them is system_health. This benchmark contains 100+ scenarios with various pages. To run it we need to have the pages snapshots (aka WPR archive), but it's restricted. We could generate it ourself, but most of the scenarios are outdated and doesn't work on the current version of the sites. Since supporting all the system_health scenarios are difficult, we are going to suppose only limited subset and mix Brave profiles with Chromium profiles to get a better coverage.
@atuchin-m
Copy link
Contributor Author

Related tasks (add stories related to generating PGO profiles): #40600

@atuchin-m
Copy link
Contributor Author

Supporting the necessary benchmarks: #40603

@atuchin-m
Copy link
Contributor Author

Support the chromium components while generating PGO profiles:
#39609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

Successfully merging a pull request may close this issue.

1 participant