Unable to open Ads from Notification center #4102

GeetaSarvadnya · 2019-04-15T10:15:10Z

Description

Unable to open Ads from Notification center

Steps to Reproduce

Set Focus Assist settings to Alarm Only in Windows OS
Clean profile 0.63.40
Enable Rewards
Open brave.com
Verify that Ads notification is displayed under the notification center
Click on the Ads notification

Actual result:

Clicking on the notifications within the notification slide, just dismisses the banner without opening brave or displaying the ad.

Expected result:

The user should be able to open the Ads

Reproduces how often:

Always

Brave version (brave://version info)

Brave	0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)
Revision	5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS	Windows 10 OS Build 17134.523

Reproducible on current release: NA

Does it reproduce on brave-browser dev/beta builds? Yes

Website problems only:

Does the issue resolve itself when disabling Brave Shields? NA
Is the issue reproducible on the latest version of Chrome? NA

Additional Information

The issue is reported by the community
https://community.brave.com/t/unable-to-open-ads-from-notification-area/49199/4

@brave/legacy_qa @tmancey

The text was updated successfully, but these errors were encountered:

GeetaSarvadnya · 2019-04-15T10:19:43Z

https://bravesoftware.slack.com/archives/C43LW5U2H/p1555318060044600?thread_ts=1555302183.044200&cid=C43LW5U2H
Comments added in above slack thread:
using undocumented and unsupported methods it is possible to detect the status of Focus Assist.
@tmancey is investigating the issue.

lukemulks · 2019-04-16T15:35:29Z

I'm running win10 x64, with Focus Assist set to Alarms Only, and am observing the notifications in the OS Notification Tray.

Brave | 0.64.47 
Chromium: 74.0.3729.61 (Official Build) dev (64-bit)
-- | --
Revision | 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS | Windows 10 OS Build 17134.706

Including a screenshot to illustrate as well.

rivy · 2019-05-14T22:23:19Z

@lukemulks , yes, the notifications are collected in the notification tray. However, they cannot be opened. Clicking on them just dismisses them without showing any ad.

Brave-Matt · 2019-05-17T19:19:52Z

+1 from Community too:
https://community.brave.com/t/notification-enabled-but-not-working/49594/63

Is there any particular reason we have this set to P4? Windows users are having enough trouble with ads/notifications as it is -- sucks to finally get them up and running only to not be able to view the ads. @rebron

rebron · 2019-05-17T22:37:32Z

@Brave-Matt I didn't set priority for this issue. I'm guessing that focus assist setting isn't a default windows setting and therefore fewer users are affected. Looks like @tmancey is looking at it though.

rivy · 2019-05-18T00:25:29Z

Notably, the ad notification will many times not open when the notification is clicked from the action center, even if "Focus Assist" is not enabled. Clicking on the floating ad works correctly, but once that panel is gone, it seems that clicking on the ad notification from within the action center slide out is generally borked.

Steps to reproduce (with default ad center settings, no focus assist)...

wait for an ad notification panel
click on the action center icon causing it to slide out
- if the ad panel within the action center is clicked at this point, it does activate the browser ad process
click outside of the action
re-open the notification center and click on the ad panel
- the ad panel closes without triggering the browser

Brave-Matt · 2019-05-18T08:50:53Z

A few users in Community troubleshooting thread reporting this as well:
https://community.brave.com/t/brave-ads-windows-10-troubleshooting/56730/13

kjozwiak · 2019-05-28T05:44:34Z

@jsecretan should we reprioritize this to maybe a P3? Seems like we're getting more +1 from Win users who are running into this. Imagine we'll want to get this fixed sooner than later.

alefnull · 2019-06-01T08:24:00Z

i've been wondering about this since installing Brave almost a week ago or so. apparently i've missed out on about 330 ads so far, and i couldn't figure out why until i finally opened the notification center (which i basically never use) and saw all the ads, started clicking on them, and nothing happened.

tmancey · 2019-06-04T08:33:49Z

@alefnull @kjozwiak @jsecretan We have identified an issue where if an Ad notification is shown and the user quits the browser, Ads will no longer open when clicked. We are working on a fix for this issue and investigating the steps reproduced by @rivy. @alefnull did you quit the browser?

alefnull · 2019-06-05T06:33:32Z

@tmancey i actually rarely close my browser, and most of the times that i've clicked on the notifications in the notification center, my browser has been open, and nothing would happen. however, since posting my last comment, the few that i've clicked have actually opened successfully. so i'm not sure what happened, as i haven't done anything differently on my end, but it does appear to be working for me now.

tmancey · 2019-06-07T08:10:30Z

@alefnull Thank you for the update

tmancey · 2019-07-16T08:26:12Z

User also reported clicking on arrow thinking it would open up the ad when instead it closed the ad. This is confusing UI/UX, investigate further and discuss with UX

rivy · 2019-07-16T16:02:49Z

Clicking the arrow to initiate "move to the notification center" is normal.

In my experience, the usual windows notification idiom with most applications is to click on the message box to open the notification or click the arrow to dismiss it to the notification center. Clicking the upper right 'X' within the notification center should completely dismiss the notification, deleting it.

All of that is working correctly.

But, when in the notification center, clicking the notification doesn't open Brave and display the ad if the ad moved directly to the notification center by "focus assist" or by clicking the arrow on the desktop panel notice to move it into the center. That's the problem this issue points out.

tmancey · 2019-07-16T16:31:56Z

@rivy thank you, much appreciated

rivy · 2019-11-23T14:57:59Z

What revision will this go out in?

My current version updated last night and this is still broken.

tmancey · 2019-11-25T09:38:45Z

@rivy This fix is currently only in 1.3, are you able to test 1.3 (currently Nightly build), please? Thanks

riswyre · 2019-11-29T10:37:56Z

give me link download

0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)

tmancey · 2019-11-29T10:39:32Z

@riswyre @rivy https://brave.com/download-nightly/

riswyre · 2019-11-29T11:06:38Z

but no ads Version 1.3.39 Chromium: 78.0.3904.108 (Official Build) nightly (32-bit)

tmancey · 2019-11-29T11:19:07Z

but no ads Version 1.3.39 Chromium: 78.0.3904.108 (Official Build) nightly (32-bit)

I have just updated here and I have updated to 1.3.39. Can you please explain "but no ads"? Thanks

riswyre · 2019-11-29T11:22:25Z

win 10 enterprise ltsc version 1809 32 bit

tmancey · 2019-11-29T11:36:00Z

@riswyre Do you have group policies etc. setup to block Windows native notifications? Do you have Focus Assist enabled?

rivy · 2019-12-05T21:14:22Z

I've just downloaded dev v1.3.57.
I'll let you know how well it works in the next few days.

rivy · 2019-12-06T05:42:50Z

After a few hours, I'm seeing no ads. ☹️

rivy · 2019-12-07T04:46:16Z

@tmancey ,

Not fixed...
No ads being displayed...

rivy · 2019-12-08T02:24:08Z

@tmancey ,

Please re-open this ... it's not fixed.

Further testing...

No ads at all with either "Focus Assist" on as either "Priority Only" or "Alarms Only".
Ads appear and do not collapse with "Focus Assist" off.
And when collapsed to the notification area using the upper right arrow, they appear in the notification area but do not open an ad in brave when clicked.

The desirable behavior is ...

With "Focus Assist" off, Ads should appear and collapse to the notification center within a reasonably short time frame (a few seconds, preferably user determined) ... not working.
If the upper right arrow of a displayed ad notice is clicked, the ad should immediately move to the notification area ... works.
Within the notification area, the ad should be clickable causing brave to display the ad (opening the application if necessary) ... not working.
With "Focus Assist" enabled (as either "Priority Only" or "Alarms Only", the ad should immediately load within the notification area and be clickable to open as above ... not working.

rivy · 2019-12-13T21:45:57Z

@tmancey , this isn't fixed.

cc: @Brave-Matt , @GeetaSarvadnya , @jsecretan , @kjozwiak

tmancey · 2019-12-14T09:05:27Z

@rivy I will update you early next, as will discuss internally. Thank you for the above testing and input. Much appreciated. Terry

btlechowski · 2020-01-04T11:39:37Z

Added OS/Windows label.

rivy · 2020-01-21T21:34:33Z

@tmancey , Checking back in ... are you planning to re-open this?

GeetaSarvadnya · 2020-01-22T08:49:46Z

@tmancey Issue is still not fixed. I am not getting any ads when Focus Assist is set to Alarm Only - Ads are not popping up or being displayed under the notification center. Let me know if I am missing anything otherwise, I will log a follow-up issue for it.

GeetaSarvadnya · 2020-01-23T19:55:25Z

As discussed with @tmancey over the slack - there is a change in the behavior as we no longer show ads if notification are not enabled. Also, we won't get any ads when Focus Assist is set to Alarm Only
The detailed test plan is provided in the PR - brave/brave-core#3084

rivy · 2020-01-24T01:34:52Z

Too bad, that's unfriendly behavior for a lot of early adopters and advocates.
But it's your circus.

GeetaSarvadnya · 2020-01-24T11:06:54Z

Verification passed on

Brave	1.3.100 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

Verified the test plan from Fix user earns while native Windows and macOS notifications are suppressed brave-core#3084
Verified we no longer see any ads if Focus Assist is set to Alarm Only Unable to open Ads from Notification center #4102 (comment)
More scenarios are tested in Fix user earns while native Windows notifications are suppressed #3651 (comment)

Clean profile:

Ensured ad notifications are NOT shown on windows when Focus Assist is enabled
[5016:6316:0124/124645.543:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
Ensured ad notification is shown when Focus Assist is disabled
[4428:16072:0124/124905.285:INFO:ads_impl.cc(1305)] Ad notification shown:

Upgrade profile:
(Upgrade from 1.2.43 to 1.3.100)

Viewed ads in 1.2.43 ads collected in the notification center when focus assist is enabled --> upgrade to 1.3.100 ads are not shown in 1.3.100, Verified notifications not allowed text message in logs
[5652:4820:0124/145717.418:INFO:ads_impl.cc(1148)] Notification not made: Notifications not allowed
Verified ads are shown when focus assist is disabled in an upgraded profile.
[9440:11284:0124/150629.389:INFO:ads_impl.cc(1305)] Ad notification shown:

Verification passed on

Brave	1.3.100 Chromium: 79.0.3945.130 (Official Build) beta (64-bit)
Revision	e22de67c28798d98833a7137c0e22876237fc40a-refs/branch-heads/3945@{#1047}
OS	Windows 10 OS Version 1909

Verified the test plan from Fix user earns while native Windows and macOS notifications are suppressed brave-core#3084
Verified we no longer see any ads if Focus Assist is set to Alarm Only Unable to open Ads from Notification center #4102 (comment)

pawsey18 · 2021-04-22T14:15:08Z

Still haven't fixed this issue yet?

tmancey · 2021-04-22T17:38:46Z

We are moving away from native notifications to brave ad notifications. Please see our nightly build for custom ad notifications, which will soon be available in other build channels. Thank you

GeetaSarvadnya added bug feature/ads QA/Yes labels Apr 15, 2019

jsecretan added the priority/P4 Planned work. We expect to get to it "soon". label Apr 15, 2019

GeetaSarvadnya mentioned this issue Apr 16, 2019

Migrate bat-native-ads to brave-core #3599

Closed

tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P4 Planned work. We expect to get to it "soon". labels Jun 4, 2019

tmancey self-assigned this Jul 8, 2019

tmancey removed their assignment Jul 17, 2019

tmancey removed the QA/Yes label Jul 17, 2019

tmancey self-assigned this Jul 17, 2019

NejcZdovc added this to the 1.3.x - Nightly milestone Nov 26, 2019

tmancey reopened this Dec 14, 2019

tmancey closed this as completed Dec 14, 2019

btlechowski added the OS/Windows label Jan 4, 2020

btlechowski added the QA Pass-Win64 label Jan 27, 2020

rebron added the release-notes/include label Feb 7, 2020

LaurenWags mentioned this issue Feb 7, 2020

Release Notes for 1.3.x (Release Channel) #8123

Closed

LaurenWags mentioned this issue Apr 13, 2020

Update Ads section of test - remove Windows only test case brave/qa-resources#166

Closed

Unable to open Ads from Notification center #4102

Unable to open Ads from Notification center #4102

Comments

GeetaSarvadnya commented Apr 15, 2019 • edited Loading

Description

Steps to Reproduce

Actual result:

Expected result:

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release: NA

Website problems only:

Additional Information

GeetaSarvadnya commented Apr 15, 2019

lukemulks commented Apr 16, 2019

rivy commented May 14, 2019

Brave-Matt commented May 17, 2019

rebron commented May 17, 2019

rivy commented May 18, 2019 • edited Loading

Brave-Matt commented May 18, 2019

kjozwiak commented May 28, 2019

alefnull commented Jun 1, 2019

tmancey commented Jun 4, 2019 • edited Loading

alefnull commented Jun 5, 2019

tmancey commented Jun 7, 2019

tmancey commented Jul 16, 2019

rivy commented Jul 16, 2019

tmancey commented Jul 16, 2019

rivy commented Nov 23, 2019

tmancey commented Nov 25, 2019 • edited Loading

riswyre commented Nov 29, 2019

0.63.40 Chromium: 74.0.3729.61 (Official Build) beta (64-bit)

tmancey commented Nov 29, 2019

riswyre commented Nov 29, 2019

tmancey commented Nov 29, 2019

riswyre commented Nov 29, 2019

tmancey commented Nov 29, 2019

rivy commented Dec 5, 2019

rivy commented Dec 6, 2019

rivy commented Dec 7, 2019 • edited Loading

rivy commented Dec 8, 2019 • edited Loading

rivy commented Dec 13, 2019 • edited Loading

tmancey commented Dec 14, 2019

btlechowski commented Jan 4, 2020

rivy commented Jan 21, 2020

GeetaSarvadnya commented Jan 22, 2020

GeetaSarvadnya commented Jan 23, 2020

rivy commented Jan 24, 2020

GeetaSarvadnya commented Jan 24, 2020 • edited by btlechowski Loading

pawsey18 commented Apr 22, 2021

tmancey commented Apr 22, 2021

GeetaSarvadnya commented Apr 15, 2019 •

edited

Loading

rivy commented May 18, 2019 •

edited

Loading

tmancey commented Jun 4, 2019 •

edited

Loading

tmancey commented Nov 25, 2019 •

edited

Loading

rivy commented Dec 7, 2019 •

edited

Loading

rivy commented Dec 8, 2019 •

edited

Loading

rivy commented Dec 13, 2019 •

edited

Loading

GeetaSarvadnya commented Jan 24, 2020 •

edited by btlechowski

Loading