Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTP UI/UE fixes to ellipsis icon #9247

Closed
3 tasks done
rebron opened this issue Apr 15, 2020 · 3 comments · Fixed by brave/brave-core#6766
Closed
3 tasks done

NTP UI/UE fixes to ellipsis icon #9247

rebron opened this issue Apr 15, 2020 · 3 comments · Fixed by brave/brave-core#6766

Comments

@rebron
Copy link
Collaborator

rebron commented Apr 15, 2020

Description

Follow-up to: #8883

Need the following UI fixes -

  • widget shadow should show as long as ellipsis icon is visible (currently it goes away if you hover over the ellipsis icon) (Steps to Reproduce Minimally brand Chromium as Brave #1)
  • ellipsis menu should not show again on hover; the user should click on the ellipsis icon again to show it (Steps to Reproduce Integrate ad block #2)
  • ellipsis icon needs more padding on stats, top sites, and clock (see Design)

Design

ellipsis icon needs more padding on stats, top sites, and clock

Steps to Reproduce

  1. Using nightly 1.9.x, hover over Brave Rewards(or front most widget) and move mouse over ellipsis icon and notice shadow (it's a faint shadow) disappears. Expected result is that shadow is still there on mouse over.

widget shadow should show as long as ellipsis icon is visible

  1. Click on an ellipsis icon, select and open menu. Move mouse away from widget area and hover back into the widget area (or near ellipsis icon) and notice that the menu is still open. Expected result is that the menu is closed and a user needs to reselect the ellipsis icon to open.

ellipsis menu should not show again on hover 2020-04-15 16_50_11

Reproduces how often:

Easily.

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

https://bravesoftware.slack.com/archives/CQUHQ0PM3/p1586549021178800

@rebron rebron added QA/Yes feature/widgets feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 15, 2020
@rebron
Copy link
Collaborator Author

rebron commented Apr 15, 2020

cc: @ryanml

@karenkliu
Copy link

@rebron @ryanml The first 2 items are fixed; all that's needed to close this issue is to adjust the ellipses icon padding.

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Linux
  • Verified test plan from issue description
    image

Verification passed on

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (64-bit)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS Windows 10 OS Version 1809 (Build 17763.1518)
  • Verified test plan from issue description
    image

Verification passed on

Brave 1.16.67 Chromium: 86.0.4240.111 (Official Build) (x86_64)
Revision b8c36128a06ebad76af51591bfec980224db5522-refs/branch-heads/4240@{#1290}
OS macOS Version 10.15.7 (Build 19H2)
  • Verified test plan from issue description
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants