Allow multiple capture groups for debounce regex action

[ShivanKaul]

Resolves brave/brave-browser#24750

Submitter Checklist:

• I confirm that no security/privacy review is needed, or that I have requested one
• There is a ticket for my issue
• Used Github auto-closing keywords in the PR description above
• Wrote a good PR/commit description
• Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
• Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
• Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
• Ran git rebase master (if needed)

Reviewer Checklist:

• A security review is not needed, or a link to one is included in the PR description
• New files have MPL-2.0 license header
• Adequate test coverage exists to prevent regressions
• Major classes, functions and non-trivial code blocks are well-commented
• Changes in component dependencies are properly reflected in gn
• Code follows the style guide
• Test plan is specified in PR before merging

After-merge Checklist:

• The associated issue milestone is set to the smallest version that the
  changes has landed on
• All relevant documentation has been updated, for instance:
  • https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)
  • https://github.com/brave/brave-browser/wiki/Proxy-redirected-URLs
  • https://github.com/brave/brave-browser/wiki/Fingerprinting-Protections
  • https://github.com/brave/brave-browser/wiki/Brave%E2%80%99s-Use-of-Referral-Codes
  • https://github.com/brave/brave-browser/wiki/Custom-Headers
  • https://github.com/brave/brave-browser/wiki/Web-Compatibility-Exceptions-in-Brave
  • https://github.com/brave/brave-browser/wiki/QA-Guide
  • https://github.com/brave/brave-browser/wiki/P3A

Test Plan:

The following URLs should get debounced to the publisher URL, once the component update goes out:

• https://topnews--ru-ru.turbopages.org/topnews-ru.ru/s/2022/08/15/djoan-royling-prigrozili-smertu-za-podderjky-ryshdi-ty-sledyushaia/ should go to https://topnews-ru.ru/2022/08/15/djoan-royling-prigrozili-smertu-za-podderjky-ryshdi-ty-sledyushaia/
• https://08-mchs-gov-ru.turbopages.org/08.mchs.gov.ru/s/deyatelnost/press-centr/novosti/4726459 should go to https://08.mchs.gov.ru/deyatelnost/press-centr/novosti/4726459

https://dev-pages.brave.software/navigation-tracking/debouncing.html, all tests should pass for regression; the one under test is Regex (multi)

[fmarier]

Instead of manually adding slashes (and potentially adding them at the end where it may not work), why not simply capture one of the slashes in a capture group?

e.g. instead of ^/([^/]+)/s/(.*)$, we could use ^/([^/]+)/s(/.*)$

[pilgrim-brave]

Not opposed to the concept. Deferring to François about the regexes. Definitely needs a lot more tests.

[fmarier]

That looks good to me, but someone more familiar with Chromium idioms should check whether that's the best way to concatenate StringPieces.

[ShivanKaul]

That looks good to me, but someone more familiar with Chromium idioms should check whether that's the best way to concatenate StringPieces.

@bridiver any thoughts? https://github.com/brave/brave-core/pull/14687/files#diff-19bb36033aacc98f6f730c5cbda666206d951a19f782c58fca555b7e44765ab3R215

I see several examples in Chromium: [1], [2], [3].

[iefremov]

this diff is not needed, existing formatting is acceptable

[ShivanKaul]

I know but I just wanted to match everything up. It helps me a tiny bit when I want to add local logging to have these, and given that they're both equivalent I thought might as well. Personally I think always specifying {} is easier to read, but no strong feelings

[MadhaviSeelam]

@ShivanKaul can you attach testplan please?

[ShivanKaul]

@MadhaviSeelam working on adding a test rule to the debounce.json list, but in the meantime the De-Yandex rules should be sufficient. I've updated the URLs to test in the test plan.

[ShivanKaul]

@MadhaviSeelam updated the test plan with the test rule: https://dev-pages.brave.software/navigation-tracking/debouncing.html, all tests should pass (thanks @pes10k!)