Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commands]: Add new commands #19035

Merged
merged 1 commit into from
Jun 26, 2023
Merged

[Commands]: Add new commands #19035

merged 1 commit into from
Jun 26, 2023

Conversation

fallaciousreasoning
Copy link
Contributor

@fallaciousreasoning fallaciousreasoning commented Jun 26, 2023

Resolves brave/brave-browser#31064
Resolves brave/brave-browser#31298

Adds new commands for:

  1. Toggling vertical tabs expansion
  2. Moving all tabs on an origin into a group
  3. Moving a group to a new window
  4. Closing duplicate tabs

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Check the commands are available on chrome://settings/system/shortcuts
  2. Check if you add a shortcut to the new commands they do what they say on the tin.

Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -254,6 +260,12 @@ void ToggleVerticalTabStripFloatingMode(Browser* browser) {
!prefs->GetBoolean(brave_tabs::kVerticalTabsFloatingEnabled));
}

void ToggleVerticalTabStripExpanded(Browser* browser) {
auto* prefs = browser->profile()->GetOriginalProfile()->GetPrefs();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As kVerticalTabsCollapsed is added to brave_pref_service_incognito_allowlist.cc, I hope we can remove GetOriginallProfile() here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call!

browser/ui/browser_commands.cc Show resolved Hide resolved
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strings: I guess it's ok to keep doing this with automatic string generation for now, but these strings tend to end up not being well formed grammatically an cause a lot of questions from localizers.
++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants