-
Notifications
You must be signed in to change notification settings - Fork 872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Commands]: Add new commands #19035
[Commands]: Add new commands #19035
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
browser/ui/browser_commands.cc
Outdated
@@ -254,6 +260,12 @@ void ToggleVerticalTabStripFloatingMode(Browser* browser) { | |||
!prefs->GetBoolean(brave_tabs::kVerticalTabsFloatingEnabled)); | |||
} | |||
|
|||
void ToggleVerticalTabStripExpanded(Browser* browser) { | |||
auto* prefs = browser->profile()->GetOriginalProfile()->GetPrefs(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As kVerticalTabsCollapsed is added to brave_pref_service_incognito_allowlist.cc
, I hope we can remove GetOriginallProfile()
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings: I guess it's ok to keep doing this with automatic string generation for now, but these strings tend to end up not being well formed grammatically an cause a lot of questions from localizers.
++
0a3e55c
to
353e4f5
Compare
Resolves brave/brave-browser#31064
Resolves brave/brave-browser#31298
Adds new commands for:
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: