Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats social sharing #8508

Merged
merged 5 commits into from
Apr 12, 2021
Merged

Stats social sharing #8508

merged 5 commits into from
Apr 12, 2021

Conversation

alexsafe
Copy link
Contributor

Resolves brave/brave-browser#15021

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Part1:

  • go on a website and go on Brave Shields. The layout row containing the number of blocked items has been changed.
  • click on the Share button and check that the right info is sent depending on the app ( for ex. mails should include the share text too, social media items just the image, etc)

Part2:

  • after hitting one of the Tiers mentioned in the docs a tooltip with a share button should appear and it should behave like the share button from above

Screen shots available from the iOS description. The Android implementation should look similar and adapted to to the OS.
image

@alexsafe alexsafe added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Apr 12, 2021
@alexsafe alexsafe added this to the 1.25.x - Nightly milestone Apr 12, 2021
@alexsafe alexsafe self-assigned this Apr 12, 2021
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. few monior comments to avoid warnings

@alexsafe alexsafe merged commit c5443ff into master Apr 12, 2021
@alexsafe alexsafe deleted the stats-social-sharing branch April 12, 2021 22:11
bsclifton added a commit that referenced this pull request May 26, 2021
This reverts commit c5443ff, reversing
changes made to 79aeb63.
kjozwiak added a commit that referenced this pull request May 27, 2021
Revert "Merge pull request #8508 from brave/stats-social-sharing"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Social Sharing of Brave Stats
3 participants