-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stats social sharing #8508
Merged
Merged
Stats social sharing #8508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexsafe
added
CI/skip-linux
CI/skip-macos-x64
Do not run CI builds for macOS x64
CI/skip-ios
Do not run CI builds for iOS
labels
Apr 12, 2021
samartnik
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
android/java/org/chromium/chrome/browser/brave_stats/BraveStatsUtil.java
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/shields/BraveShieldsHandler.java
Outdated
Show resolved
Hide resolved
deeppandya
approved these changes
Apr 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. few monior comments to avoid warnings
android/java/org/chromium/chrome/browser/brave_stats/BraveStatsUtil.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/brave_stats/BraveStatsUtil.java
Outdated
Show resolved
Hide resolved
android/java/org/chromium/chrome/browser/brave_stats/BraveStatsUtil.java
Outdated
Show resolved
Hide resolved
24 tasks
kjozwiak
added a commit
that referenced
this pull request
May 27, 2021
Revert "Merge pull request #8508 from brave/stats-social-sharing"
kylehickinson
pushed a commit
that referenced
this pull request
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#15021
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Part1:
Part2:
Screen shots available from the iOS description. The Android implementation should look similar and adapted to to the OS.