Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Implement P3A on iOS #1938

Closed
anthonypkeane opened this issue Nov 12, 2019 · 11 comments · Fixed by #6308
Closed

Implement P3A on iOS #1938

anthonypkeane opened this issue Nov 12, 2019 · 11 comments · Fixed by #6308
Assignees
@kylehickinson @soner-yuksel
Labels
enhancement QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.46

Comments

@anthonypkeane
Copy link

anthonypkeane commented Nov 12, 2019 •
edited by soner-yuksel
Loading

Description:

UI can be found

Onboarding:
https://www.figma.com/file/irDJRP35FUwsRu60Wp9fM6/iOS-onboarding?node-id=3321%3A54735

Settings:
https://www.figma.com/file/SLFLpMd7F7Tu58qGBdcUQG/iOS-Settings?node-id=1873%3A15338

Security Ticket: https://github.com/brave/security/issues/1088
@anthonypkeane anthonypkeane added this to the 1.16 milestone Dec 11, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.16, 1.17 Feb 12, 2020
@anthonypkeane anthonypkeane removed this from the 1.17 milestone May 14, 2020
@bsclifton
Copy link
Member

bsclifton commented Oct 24, 2022 •
edited
Loading

From brave/brave-browser#12723 (Android version of P3A onboarding; linked from brave/brave-browser#6688)

We have this on Android for onboarding:
Screen 1

Screen 2

@bradleyrichter
Copy link

Yes, please implement the new onboarding screen on iOS with the same choices and strings.

@bsclifton
Copy link
Member

cc: @kylehickinson ^^

@anthonypkeane
Copy link
Author

We don't have diagnostic reporting on iOS so the 1st option isn't necessary.

@Sam-Sibley I saw your Desktop design and it seems to be a little nicer vs what we have on Android. Can we use an iteration of that on iOS?

Thanks

@anthonypkeane anthonypkeane added the blocked: needs design Needs design before work can commence label Oct 25, 2022
@kylehickinson
Copy link
Collaborator

Also would be good to know what we want to do for existing users design and implementation wise

@bradleyrichter
Copy link

image for reference to comment above:
image

@anthonypkeane
Copy link
Author

anthonypkeane commented Oct 27, 2022 •
edited
Loading

There are 3 items we need for this issue

  1. The UI for P3A during onboarding
  2. A flow (and UI) for existing users
  3. A setting to enable/disable P3A

  1. @Sam-Sibley has a design and will share it here soon

  2. We can show the above card in 1 to all existing users on upgrade and first launch.

  3. For the Setting

Title: Allow Privacy-Preserving Product Analytics (P3A)
Subtitle: Anonymized P3A info helps Brave estimate overall usage and ensure we're improving popular features

Please place this setting in Brave Shields & Privacy and under the Privacy Hub setting.

@Sam-Sibley pls confirm if this works okay

kylehickinson added a commit that referenced this issue Oct 27, 2022
@kylehickinson
Fix #1938: Initialize P3A service and add P3A pref in settings
6e0a77d
kylehickinson added a commit that referenced this issue Oct 27, 2022
@kylehickinson
Fix #1938: Initialize P3A service and add P3A pref in settings
553f9da
kylehickinson added a commit that referenced this issue Oct 27, 2022
@kylehickinson
Fix #1938: Initialize P3A service and add P3A pref in settings
8bf93dc
kylehickinson added a commit that referenced this issue Oct 27, 2022
@kylehickinson
Fix #1938: Initialize P3A service and add P3A pref in settings
1a06681
@anthonypkeane
Copy link
Author

  1. @Sam-Sibley has a design and will share it here soon
  2. We can show the above card in 1 to all existing users on upgrade and first launch.
  3. For the Setting

Title: Allow Privacy-Preserving Product Analytics (P3A) Subtitle: Anonymized P3A info helps Brave estimate overall usage and ensure we're improving popular features

Please place this setting in Brave Shields & Privacy and under the Privacy Hub setting.

@Sam-Sibley pls confirm if this works okay

--> There are a few updates to the above. Sam will post the UI and flow shortly. Thanks

@anthonypkeane
Copy link
Author

Settings UI: https://www.figma.com/file/SLFLpMd7F7Tu58qGBdcUQG/iOS-Settings?node-id=1873%3A15338

Onboarding: https://www.figma.com/file/irDJRP35FUwsRu60Wp9fM6/iOS-onboarding?node-id=3321%3A54735

P3A card to be shows after Set Default (but before the user can enter a URL
For existing, on first launch after upgrade show the card.

Screen Shot 2022-10-28 at 10 37 22 AM

(Note: UI is correct on Figma not on this image, this image is to detail the position of the P3A card)

@iccub iccub removed the blocked: needs design Needs design before work can commence label Oct 28, 2022
soner-yuksel pushed a commit that referenced this issue Oct 31, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
7ef5134
soner-yuksel pushed a commit that referenced this issue Oct 31, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
004eb44
soner-yuksel pushed a commit that referenced this issue Nov 1, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
0936df2
soner-yuksel pushed a commit that referenced this issue Nov 2, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
fe22b15
@soner-yuksel soner-yuksel mentioned this issue Nov 2, 2022
Merged
11 tasks
@iccub iccub added this to the 1.46 milestone Nov 2, 2022
soner-yuksel pushed a commit that referenced this issue Nov 8, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
d54a1d9
soner-yuksel pushed a commit that referenced this issue Nov 9, 2022
@kylehickinson @soner-yuksel
Fix #1938: Initialize P3A service and add P3A pref in settings
7158f98
soner-yuksel added a commit that referenced this issue Nov 16, 2022
@soner-yuksel
Fix #1938: Implement P3A on iOS (#6308)
caf52a2
@soner-yuksel soner-yuksel mentioned this issue Nov 23, 2022
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Nov 24, 2022
@soner-yuksel
[Follow Up] #1938: P3A alignment and UI fixes for onboarding (#6470)
7661852
@soner-yuksel soner-yuksel mentioned this issue Nov 28, 2022
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Nov 28, 2022
@soner-yuksel
Ref #1938: Settings P3A Localization (#6497)
c7486f2
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 1, 2022 •
edited
Loading

Verification PASSED on iPhone 8 iOS version 16.1.1 running Brave 1.46 (22.12.1.14)

1. Verify P3A card/slide in the onboarding

New user

  • Confirmed that P3A Slide is shown in the onbrading after Set Default card/slide
  • Confirmed that P3A modal text is matching with the Figma spec
  • Confirmed that P3A switch can be turned off/on
  • Confirmed updated P3A switch state is retained in the P3A settings under Brave Shields & Privacy
  • Switch state is not retained after the browser restart, logged Turn off/on state isn't retained for the P3A switch after the browser restart #6537
  • Confirmed that controls inside the P3A modal works as expected
  • Confirmed that click on the learn more link opens up the support.brave.com page
Light mode Dark mode
IMG_3220 IMG_3222

Existing user

  • Confirmed that P3A Slide is shown on the NTP on the first launch in an upgraded profile
  • Confirmed that P3A modal text is matching with the Figma spec
  • Confirmed that P3A switch can be turned off/on
  • Confirmed updated P3A switch state is retained in the P3A settings under Brave Shields & Privacy
  • Switch state is not retained after the browser restart, logged Turn off/on state isn't retained for the P3A switch after the browser restart #6537
  • Confirmed that controls inside the P3A modal works as expected
  • Confirmed that click on the learn more link opens up the support.brave.com page
Light mode Dark mode
IMG_3225 IMG_3226

2. Verify P3A settings

  • Confirmed that P3A settings Allow Privacy-Preserving Product Analytics (P3A) is placed under Brave Shields & Privacy and under the Other Privacy Settings section
  • Confirmed that the Subtitle: Anonymized P3A info helps Brave estimate overall usage and ensure we're improving popular features is shown below the P3A settings
  • Confirmed that P3A switch can be turned off/on
  • Confirmed that P3A settings Allow Privacy-Preserving Product Analytics (P3A) is placed in both clean and upgrded profile of 1.46.x
Light mode Dark mode
IMG_3227 IMG_3228

@soner-yuksel soner-yuksel mentioned this issue Dec 2, 2022
Merged
11 tasks
soner-yuksel added a commit that referenced this issue Dec 2, 2022
@soner-yuksel
Ref #1938: Settings P3A Title Case (#6540)
68f612c
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 8, 2022 •
edited
Loading

Verification PASSED on iPad 7th Generation version 15.2 running Brave 1.46 (22.12.7.22)

1. Verify P3A card/slide in the onboarding

New user

  • Confirmed that P3A Slide is shown in the onbrading after Set Default card/slide
  • Confirmed that P3A modal text is matching with the Figma spec
  • Confirmed that P3A switch can be turned off/on
  • Confirmed updated P3A switch state is retained in the P3A settings under Brave Shields & Privacy
  • Switch state is not retained after the browser restart, logged Turn off/on state isn't retained for the P3A switch after the browser restart #6537
  • Confirmed that controls inside the P3A modal works as expected
  • Confirmed that click on the learn more link opens up the support.brave.com page
Light mode Dark mode
IMG_0301 IMG_0302

Existing user

  • Confirmed that P3A Slide is shown on the NTP on the first launch in an upgraded profile
  • Confirmed that P3A modal text is matching with the Figma spec
  • Confirmed that P3A switch can be turned off/on
  • Confirmed updated P3A switch state is retained in the P3A settings under Brave Shields & Privacy
  • Switch state is not retained after the browser restart, logged Turn off/on state isn't retained for the P3A switch after the browser restart #6537
  • Confirmed that controls inside the P3A modal works as expected
  • Confirmed that click on the learn more link opens up the support.brave.com page
Light mode Dark mode
IMG_0304 IMG_0303

2. Verify P3A settings

  • Confirmed that P3A settings Allow Privacy-Preserving Product Analytics (P3A) is placed under Brave Shields & Privacy and under the Other Privacy Settings section
  • Confirmed that the Subtitle: Anonymized P3A info helps Brave estimate overall usage and ensure we're improving popular features is shown below the P3A settings
  • Confirmed that P3A switch can be turned off/on
  • Confirmed that P3A settings Allow Privacy-Preserving Product Analytics (P3A) is placed in both clean and upgrded profile of 1.46.x
Light mode Dark mode
IMG_0306 IMG_0307

Brandon-T pushed a commit that referenced this issue Dec 13, 2022
@soner-yuksel @Brandon-T
Ref #1938: Settings P3A Title Case (#6540)
b7d6bfb
@anthonypkeane anthonypkeane mentioned this issue Sep 13, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

@soner-yuksel soner-yuksel

Labels
enhancement QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.46
Development

Successfully merging a pull request may close this issue.

Fix #1938: Implement P3A on iOS brave/brave-ios
9 participants
@jamesmudgett @kylehickinson @kjozwiak @bsclifton @soner-yuksel @iccub @anthonypkeane @bradleyrichter @GeetaSarvadnya