Skip to content

Join is using alias column names #221

@thadclay

Description

@thadclay
var sql = require('sql');

var user = sql.define({
  name: 'user',
  columns: ['id', 'name', 'email', 'lastLogin']
});

var friendship = sql.define({
  name: 'friendship',
  columns: [
    { name: 'user_id', property: 'some_alias_here' },
    { name: 'friendId' }
  ]
});

var friends = user.as('friends');
var userToFriends = user
  .leftJoin(friendship).on(user.id.equals(friendship.some_alias_here))

console.log(userToFriends.toString());

The result of userToFriends is

"user" LEFT JOIN "friendship" ON ("user"."id" = "friendship"."user_id" AS "some_alias_here")

The proper result should be

"user" LEFT JOIN "friendship" ON ("user"."id" = "friendship"."user_id")

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions