Skip to content

join: confusing declarations #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

join: confusing declarations #953

merged 1 commit into from
Feb 19, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Feb 19, 2025

  • Simplify code to make it clearer to the reader that get_arg() has only one function parameter, i.e. $arg
  • Update loops using do-until-not pattern instead of regular do-while; found by perlcritic
%perl cat names # regression test
1 BoB
2 Budii
3 B-LITE
10 BLINK
%perl cat prices
1 $500
2 $30
3 50c
6 $2
%perl join names prices
1 BoB $500
2 Budii $30
3 B-LITE 50c

@mknos
join: confusing declarations
95b79a8 
* Simplify code in get_opt() to make it clearer to reader that there is only one function parameter, i.e. $arg
* Update 2 loops using until-not pattern instead of regular while pattern; found by perlcritic

%perl cat names # regression test
1 BoB
2 Budii
3 B-LITE
10 BLINK
%perl cat prices
1 $500
2 $30
3 50c
6 $2
%perl join names prices
1 BoB $500
2 Budii $30
3 B-LITE 50c
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: join The join program labels Feb 19, 2025
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:23 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 06:24 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13406661534

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.389%
Totals Coverage Status
Change from base Build 13285364908: 0.0%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Feb 19, 2025
briandfoy
briandfoy approved these changes Feb 19, 2025
View reviewed changes
@briandfoy briandfoy merged commit de00a20 into briandfoy:master Feb 19, 2025
23 checks passed
@briandfoy briandfoy added Status: accepted The fix is accepted and removed Priority: low get to this whenever labels Feb 19, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: join The join program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy