Skip to content

chgrp: redundant file check #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2025
Merged

chgrp: redundant file check #954

merged 1 commit into from
Feb 19, 2025

Conversation

@mknos
Copy link
Contributor

@mknos mknos commented Feb 19, 2025

  • In modify_file(), delete a -e file check immediately before stat()ing the file
  • Allow stat() to fail; it will cover the case where the file argument doesn't exist
%perl chgrp root a/b/c/d
chgrp: failed to stat 'a/b/c/d': No such file or directory

@mknos
chgrp: redundant file check
2c34306 
* In modify_file(), delete a -e file check immediately before stat()ing the file
* Allow stat() to fail; it will cover the case where the file argument doesn't exist

%perl chgrp root a/b/c/d
chgrp: failed to stat 'a/b/c/d': No such file or directory
@github-actions github-actions bot added Type: enhancement improve a feature that already exists Priority: low get to this whenever Program: chgrp The chgrp program labels Feb 19, 2025
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:31 — with GitHub Actions Inactive
@mknos mknos temporarily deployed to automated_testing February 19, 2025 08:32 — with GitHub Actions Inactive
@coveralls
Copy link

coveralls commented Feb 19, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 13408376688

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 73.389%
Totals Coverage Status
Change from base Build 13285364908: 0.0%
Covered Lines: 353
Relevant Lines: 481
💛 - Coveralls

@briandfoy briandfoy self-assigned this Feb 19, 2025
@briandfoy briandfoy merged commit c52d296 into briandfoy:master Feb 19, 2025
23 checks passed
@briandfoy briandfoy removed the Priority: low get to this whenever label Feb 19, 2025
@briandfoy briandfoy added the Status: accepted The fix is accepted label Feb 19, 2025
@briandfoy briandfoy added Status: released there is a new release with this fix and removed Status: accepted The fix is accepted labels Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@briandfoy briandfoy briandfoy approved these changes

Assignees

@briandfoy briandfoy

Labels

Program: chgrp The chgrp program Status: released there is a new release with this fix Type: enhancement improve a feature that already exists

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mknos @coveralls @briandfoy