Fixes issue #22 : failed tests on MSYS2 #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems it is not possible to make files unreadable on MSYS2. Skipped the tests that checked for readable bit. Also added 'msys' to the _win32() sub such that MSYS2 is treated as Win32 in the tests.
1 similar comment
Contributor
Author
|
Seems like some tests fail under Strawberry Perl on Windows, I am looking into it. |
The test writeable_fails in t/test_files.t assumes that a UID==0 or EUID==0 implies running with elevated privileges. It seems this is not the case for MSWin32.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #22. It seems it is not possible to make files unreadable on MSYS2. Skipped the tests that checked for readable bit. Also added 'msys' to the
_win32()sub such that MSYS2 is treated as Win32 in the tests. The test suite now passes on my machine.