Skip to content

Conversation

@blshukla
Copy link
Contributor

@blshukla blshukla commented Mar 12, 2025

📝 Description

  • Add an example HTML and JS application that scans for Bluetooth devices

Issue: https://brightsign.atlassian.net/browse/PE-616

🧪 Steps to Test

Copy the autorun.brs and index.html files to the root of the SD card and insert it into a BrightSign player. Reboot the player.

📸 Screenshots

bluetooth-scan

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

Copy link
Contributor

@jdmedlin1 jdmedlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blshukla
Copy link
Contributor Author

@evan-morgan @gostoshbs @bhastings1019 Could I get another review on this PR? Thanks in advance!

@blshukla blshukla requested review from gostoshbs and jdmedlin1 March 24, 2025 22:14
Copy link
Contributor

@jdmedlin1 jdmedlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@blshukla
Copy link
Contributor Author

@jdmedlin1 Thanks for the review. Could you help me resolve the CI action failure?

blshukla added 5 commits April 1, 2025 15:10
- Add an example HTML and JS application that scans for Bluetooth devices
- Remove Ethernet / WiFi requirement from the Pre-requisites list
- Add BT event parameters in method comment block for reference
- Also add telent/ssh doc link
Copy link
Contributor

@jdmedlin1 jdmedlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@blshukla blshukla merged commit 22ee259 into main Apr 1, 2025
2 checks passed
@blshukla blshukla deleted the PE-616 branch April 1, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants