-
Notifications
You must be signed in to change notification settings - Fork 3
feat: PE-616: Create JS example app for scanning bluetooth devices #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jdmedlin1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@evan-morgan @gostoshbs @bhastings1019 Could I get another review on this PR? Thanks in advance! |
jdmedlin1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
|
@jdmedlin1 Thanks for the review. Could you help me resolve the CI action failure? |
- Add an example HTML and JS application that scans for Bluetooth devices
- Remove Ethernet / WiFi requirement from the Pre-requisites list - Add BT event parameters in method comment block for reference
- Also add telent/ssh doc link
jdmedlin1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
📝 Description
Issue: https://brightsign.atlassian.net/browse/PE-616
🧪 Steps to Test
Copy the
autorun.brsandindex.htmlfiles to the root of the SD card and insert it into a BrightSign player. Reboot the player.📸 Screenshots
✔️ Dev Complete Checklist