fix(PE-817): remove dependencies that are not supported in node v14 #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blshukla
approved these changes
Apr 1, 2025
Contributor
blshukla
left a comment
blshukla
left a comment
There was a problem hiding this comment.
The changes look okay, assuming they worked okay after testing. One feedback I have is that the PR description need to be updated as per the template. If there is no list of changes or test steps, then let's remove those sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
The bsc tool requires node version 20 or higher to run. The dev-cookbook is set to node v14. Thus, we must remove the use of the tool from the repo so there is no CI error from version incompatibility.
📋 List of Changes
package.json for applications that included the bsc tool in their scripts have been modified to remove said scripts. The tool is not compatible with node v14.