-
Notifications
You must be signed in to change notification settings - Fork 3
feat(PE-1039): Add examples to enable ldws on a player #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR provides comprehensive documentation and code examples for enabling the Local Diagnostic Web Server (LDWS) on BrightSign devices. It demonstrates three different implementation approaches to help developers choose the best method for their specific use case.
- Adds three different methods to enable LDWS: BrightScript with roNetworkConfiguration, Node.js with @brightsign/dwsconfiguration, and direct registry manipulation
- Provides comprehensive documentation with setup instructions, security considerations, and troubleshooting guidance
- Includes working code examples for each method with proper error handling and configuration options
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| registry.brs | BrightScript example using direct registry manipulation to configure LDWS |
| index.js | Node.js example using @brightsign/dwsconfiguration module for LDWS setup |
| autorun.brs | BrightScript example using roNetworkConfiguration API (recommended approach) |
| autorun-nodejs.brs | BrightScript autorun file to launch the Node.js LDWS configuration |
| README.md | Comprehensive documentation covering all three methods with usage instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
evan-morgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…bling default disabled local dws players
… readme to provide solution for players that have ldws disabled via setup, not just disabled by default
📝 Description
This branch provides clear documentation and updated code samples that demonstrate three different methods to enable the Local Diagnostic Web Server (LDWS) on BrightSign devices: using BrightScript, Node.js, and direct registry settings. The example helps developers choose and implement the best approach for enabling LDWS in their projects.
Issue: Url to Jira Issue
📋 List of Changes
🧪 Steps to Test
Run each example on your player.
✔️ Dev Complete Checklist