Skip to content

Conversation

@blshukla
Copy link
Contributor

@blshukla blshukla commented Sep 18, 2025

📝 Description

  • Add the creation of brightsign-dumps folder in some examples
  • Add a note in examples/README as well

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

- Add the creation of `brightsing-dumps` folder in some examples
- Add a note in examples/README as well
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for creating a "brightsign-dumps" directory in BrightScript example files to store crash information for debugging purposes. The changes ensure that crash dumps can be collected by BrightSign OS for troubleshooting support.

  • Added directory creation code to three example autorun.brs files
  • Added documentation in the examples README explaining the purpose of the brightsign-dumps folder

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
examples/node-starter-example/autorun.brs Added crash-dumps directory creation with error handling
examples/node-simple-server-example/src/autorun.brs Added crash-dumps directory creation with error handling
examples/html-starter-example/autorun.brs Added crash-dumps directory creation with error handling
examples/README.md Added documentation explaining the brightsign-dumps folder purpose

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

jdmedlin1
jdmedlin1 previously approved these changes Sep 25, 2025
@jdmedlin1
Copy link
Contributor

Do the templates need this change too?

@blshukla
Copy link
Contributor Author

Do the templates need this change too?

Good point. I've added in the 3 templates we have.

@blshukla blshukla merged commit d62a28a into main Sep 25, 2025
2 checks passed
@blshukla blshukla deleted the PE-983 branch September 25, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants