Skip to content

Conversation

@blshukla
Copy link
Contributor

@blshukla blshukla commented Oct 21, 2025

📝 Description

  • Update BSMessagePort -> @brightsign/messageport in the HTML file.
  • Fix undefined error with msg.data

Issue: PE-1075

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

Copilot AI review requested due to automatic review settings October 21, 2025 22:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the send-plugin-message example to use the @brightsign/messageport package instead of the deprecated BSMessagePort API, and fixes a bug where message data was incorrectly accessed via msg.data instead of msg directly.

  • Updates the HTML file to use the modern @brightsign/messageport module instead of the deprecated BSMessagePort
  • Fixes incorrect message data access pattern by changing msg.data["property"] to msg["property"]
  • Adds documentation for a new MessagePort example in the README

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
examples/send-plugin-message/pluginMessageApp.html Updates to use @brightsign/messageport module and fixes message data access pattern
examples/send-plugin-message/plugin-message-transfer.bpfx Updates project metadata including version, timestamps, and file paths
examples/README.md Adds documentation for the MessagePort example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@jdmedlin1 jdmedlin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. Thanks!

@blshukla blshukla merged commit 1519f74 into main Nov 6, 2025
2 checks passed
@blshukla blshukla deleted the PE-1075 branch November 6, 2025 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants