Skip to content

Conversation

@jdmedlin1
Copy link
Contributor

📝 Description

The changes involving the RED compliance release will include players now using self-signed certs when communicating via the local DWS. This example serves as a reference for customers who are curious how to handle self signed certs.

Issue: Url to Jira Issue

📋 List of Changes

  • README explaining focus of example
  • index.js with code

🧪 Steps to Test

  1. Replace ip with your player's ip address and trigger fetch on player that prefers https protocol

✔️ Dev Complete Checklist

  • PR template filled out
  • Change is tested by submitter
  • PR follows all linting and coding standards
  • Github Issue exists (if applicable)
  • Team member has been assigned
  • At least one commit message is in Conventional Commit format

Copilot AI review requested due to automatic review settings November 1, 2025 00:33
@jdmedlin1 jdmedlin1 self-assigned this Nov 1, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new example demonstrating how to handle self-signed certificates when communicating with BrightSign players via the local Diagnostic Web Server (DWS). This is important because BrightSign players use self-signed certificates for HTTPS communication by default.

Key changes:

  • Creates a new example with configuration for accepting self-signed certificates using undici's Agent
  • Provides documentation on security considerations and proper usage scenarios
  • Includes step-by-step instructions for running the example

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
examples/self-signed-certs-example/index.js Implements HTTPS agent configuration with rejectUnauthorized: false and a sample function for communicating with BrightSign players
examples/self-signed-certs-example/README.md Provides comprehensive documentation including setup instructions, security notes, and usage guidelines

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

@evan-morgan evan-morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdmedlin1 jdmedlin1 requested a review from blshukla November 15, 2025 00:05
@jdmedlin1 jdmedlin1 merged commit df21dc3 into main Nov 25, 2025
8 checks passed
@jdmedlin1 jdmedlin1 deleted the PE-1060 branch November 25, 2025 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants