Dev test on Node.js 6 etc. on Linux, mac OS, and Windows#3
Draft
brody2consult wants to merge 8 commits intomainfrom
Draft
Dev test on Node.js 6 etc. on Linux, mac OS, and Windows#3brody2consult wants to merge 8 commits intomainfrom
brody2consult wants to merge 8 commits intomainfrom
Conversation
added 3 commits
August 8, 2019 11:14
using the `--ignore-engines` flag on Yarn, as needed on Node.js 6
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using the
--ignore-enginesflag on Yarn, as needed on Node.js 6in order to avoid mistakes such as get-stream@5 update, which breaks installation from GitHub on Node.js version 6
NOTE: This proposal is known to fail on Node.js version 6 on mac OS due to timeout, on Windows with an error, and sometimes on Linux due to a seg fault.
I can think of the following possible workarounds in case the build does not succeed on Linux or Windows:
test-integrationon Node.js 6, like I proposed in test-integration on Azure Pipelines #1;yarn testwith Jest in smaller parts-iflag (short for--runInBandflag)