-
-
Notifications
You must be signed in to change notification settings - Fork 11
Support for Vapor 4 #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Update visiblity
Vapor 4 conversion
|
@0xTim ready for review 🎉 |
0xTim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Few comments and things that can be updated. Some other things to look at are:
- use async/await throughout the tests assuming it's available to us. Updating the manifest to 5.5 and macOS 12 will help
- we don't have any CI any more, we should set up GH actions to run the tests to make sure things work
|
@0xTim Thanks for the feedback! Can you take a look again? |
|
Also, I was thinking to extend .field("location", .geometricPoint2D)instead of: .field("location", GeometricPoint2D.dataType)What do you think? |
|
@PoshAlpaca yep I think that's a great idea to provide a cleaner API |
0xTim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Last couple of changes just to CI then we're good. We should have CI passing in this PR
And let's add the data type stuff as well if it's simple
0xTim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Might need to tweak the on section of CI to get it to run or wait until it's merged. Happy to merge however and fix in another PR if necessary
Adds support for Vapor 4. Originally implemented by rabc. I've combined it with our custom
filterGeographyDistanceWithinandsortByDistancefunctions.