Fix #1829 #1813 #1831 #1836
Merged
Fix #1829 #1813 #1831 #1836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
October 5, 2025 22:18
…` method to bad-chart and multi-bar-chart The given bandwidth must be in (0, 1], and represents the percentage of available space filled by bars: - 0% bandwidth would be zero-width bars - 100% bandwidth would have no padding between bars The default bandwidth is 80%
…ter plots, and adding non-linear axes
- the padding is handled as best as I can manage, by measuring the images' overhang in pixels outside the edges of the chart,
then inverting those pixels back into domain units, and extending the axes by those amounts. this is not quite right,
since there is additional padding outside the chart area, but it's pretty good. (this padding is needed because the extreme
points of a scatter plot are clipped by the chart area, which in turn is needed to ensure composite plots are of reasonable size)
- the non-linear axes are supported by adding a new pair of window methods, `.{x,y}-axis-type(type)`, and a new enum
- at-linear
- at-pow(power) ==> quadratic, cubic, square-root, etc
- at-log(base) ==> logarithmic
- at-symlog(constant) ==> symmetric-logarithmic
Vega does not support exponential-mapped axes, which is probably fine...
Images being non-clipped on non-linear axes is not guaranteed (in fact, since the axes compress the extreme values,
it's more likely than not!)
The real problem with #1813 was that OverlayImage was using the .pinholeX/Y fields without first checking for existence, which is what the .getPinholeX/Y() methods are for. The real fix is therefore to use those methods everywhere.
…nerating console spew), and add tests
- marks *all* axes as explicitly containing zero or not, rather than relying on defaults - also fixes incorrect margin calculations when images aren't used - also fixes incorrect clipping region coordinates (reverts experimental change) - fixes various typos of left/right/top/down/[0]/[1]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1829 -- various charts visual changes (and new features)
fixes #1813 -- chart images need pinholes
fixes #1831 -- image-url doesn't work offline because of setAttribute missing