Skip to content

Conversation

@shrey150
Copy link
Contributor

@shrey150 shrey150 commented Nov 15, 2025

Fix instructions for users running MCP over SHTTP

@shrey150 shrey150 requested a review from Kylejeong2 November 15, 2025 00:02
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Nov 15, 2025

Greptile Overview

Greptile Summary

Added type: "http" field to the MCP client configuration example printed by the HTTP transport server. This clarifies the transport protocol for MCP clients.

  • Updated configuration example in console output to include explicit transport type
  • Improves clarity for users configuring HTTP transport

Confidence Score: 5/5

  • This PR is safe to merge - it's a simple documentation update to configuration output
  • Single-line addition that only updates a JSON configuration example in console output. No logic changes, no runtime behavior modifications, and follows standard MCP transport configuration format.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
src/transport.ts 5/5 Added type: "http" field to MCP client configuration example for HTTP transport

Sequence Diagram

sequenceDiagram
    participant User
    participant HTTPServer
    participant Console
    
    User->>HTTPServer: Start HTTP transport
    HTTPServer->>HTTPServer: Listen on port
    HTTPServer->>Console: Log server info
    Console->>User: Display config with type: "http"
    Note over Console,User: Updated config example now includes<br/>type field for HTTP transport
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

{
mcpServers: {
browserbase: {
type: "http",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Check if README.md (lines 64-71) should also be updated - SHTTP examples there don't include the type field

Prompt To Fix With AI
This is a comment left during a code review.
Path: src/transport.ts
Line: 106:106

Comment:
**style:** Check if README.md (lines 64-71) should also be updated - SHTTP examples there don't include the `type` field

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Member

@Kylejeong2 Kylejeong2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shrey150 shrey150 merged commit 7e36532 into main Nov 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants