Skip to content

Conversation

seanmcguire12
Copy link
Member

why

  • cleaning up unused code

test plan

  • regression evals

Copy link

changeset-bot bot commented May 14, 2025

🦋 Changeset detected

Latest commit: cfee592

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR removes several unused code elements across multiple files, including error classes and utility functions. The changes require careful review to ensure no breaking changes. - Removed StagehandNotImplementedError and StagehandDeprecationError classes from /types/stagehandErrors.ts - Removed getNearestScrollableParent DOM traversal function from /lib/dom/process.ts - Removed generateId and logLineToString utility functions from /lib/utils.ts - Test plan only mentions 'regression evals' - recommend expanding test coverage to verify no dependencies on removed code - Consider documenting these removals in CHANGELOG.md for better version tracking

3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@seanmcguire12 seanmcguire12 merged commit 98e1356 into main May 15, 2025
14 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants