Fix new tab url intercept for aboutblank #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ca4b2d3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves browser launch performance and fixes URL handling for new tabs by modifying browser configuration and navigation logic.
- Added URL validation in
lib/handlers/handlerUtils/actHandlerUtils.tsto prevent navigation to 'about:blank' URLs from new tabs - Removed performance-impacting Chromium flags (
--enable-webgl,--use-gl=swiftshader, etc.) from browser launch config inlib/index.ts - Added check in
handlePossiblePageNavigationto validate new tab URLs before navigation - Maintained existing logging and error handling patterns for consistency
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
kamath
reviewed
May 22, 2025
seanmcguire12
approved these changes
May 22, 2025
miguelg719
force-pushed
the
miguel/stg-446-fix-new-tab-url-intercept-for-aboutblank
branch
from
07509ad to
ca4b2d3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
why
New tabs opened by popups/link redirects could contain invalid urls
what changed
Avoid tab redirect on main page with an invalid url
test plan