Skip to content

Conversation

@jmm
Copy link
Contributor

@jmm jmm commented Jan 21, 2015

Fix #60.

There were several tests in test/resolver.js for the Cannot find module error and I added new tests at a couple of those locations. It didn't seem like there'd be any additional value to add new tests at the other locations -- do you agree?

The next step toward exposing this in browserify will be getting browser-resolve to bump the resolve version.

@Irrelon
Copy link

Irrelon commented Mar 25, 2015

Really useful to have this. Browserify "cannot find module from" error really needs this info!

@jmm
Copy link
Contributor Author

jmm commented Feb 5, 2016

@obuchtala
Copy link

Any chance that this PR gets merged?

@ljharb
Copy link
Member

ljharb commented Dec 13, 2016

@jmm would you mind rebasing this and rerunning tests? (or checking the "allow maintainers to edit" checkbox)

@tcchau
Copy link
Contributor

tcchau commented May 25, 2017

@ljharb @jmm It would be really nice to have this resolved. Is there anything I can do to help?

@ljharb
Copy link
Member

ljharb commented May 25, 2017

@tcchau one of the two options in #64 (comment) would be ideal, so that we don't need to open a new PR.

@tcchau
Copy link
Contributor

tcchau commented May 25, 2017

@ljharb Ah, I see, so as long as @jmm owns the PR no one else can really help this move forward unless there's a new PR created with the same changes!

@tcchau
Copy link
Contributor

tcchau commented May 27, 2017

@ljharb I've resolved the conflicts and ensured that the tests pass in my fork of the repository after pulling from @jmm's branch. I needed the changes incorporated for a current project anyway. If you think this can help, let me know and I'll issue a PR.

@goto-bus-stop
Copy link
Member

@tcchau if you are still interested in tackling this, opening a new PR would be great :)

@tcchau
Copy link
Contributor

tcchau commented May 18, 2018

Hi @goto-bus-stop I will see if I can find that repo again. I've since stopped using browserify and moved on to webpack, but I'm happy to issue the PR. I need to figure what this issue was, then probably rebase with the latest and then submit. Stay tuned I guess!

@tcchau
Copy link
Contributor

tcchau commented May 23, 2018

Hi @goto-bus-stop, I've submitted a PR #161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

"Error: Cannot find module" output should include filename

6 participants