no lax vector conversions for clang on ARM #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recent versions of sse2neon.h (included through simd_utils) do not build using (apple) clang and -flax-vector-conversions. (apple) clang builds (other than gcc) do not need this option though, therefore do not add it if clang is used.
xxnuo
added a commit
to xxnuo/marian-dev
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
recent versions of sse2neon.h (included through simd_utils) do not build using clang and with
-flax-vector-conversions.clang builds (other than gcc) do not need this option though, therefore do not add it if clang is used.
Current code, when configured on ARM, configures with simd_utils, and
-flax-vector-conversions.List of changes:
-flax-vector-conversionsif compiler is not clangAdded dependencies: none
How to test
Try to build current code with clang on any ARM CPU against latest simd-utils. The build will fail.
With this patch applied, the build passes on ARM, with clang.
Checklist