Adds -localIdentifier to stop command #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, stop will close all instances of BrowserStackLocal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was seeing a bug:
If I have multiple BrowserStackLocal tunnels running with a localIdentifier and stop any one of them, all tunnels get closed.
This pull request adds a test for that behavior, and adds a localIdentifier to the stop command.
As part of the testing, I also changed the functioning of Local#isRunning. This previously returned
nilif the process had been stopped (@pid was nil) It now returns false.This passes tests on my machine, but there may be cases that are not covered on other OS or ruby version.