Skip to content

Ruby 3 fix: exist? instead of exists? #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 24, 2023
Merged

Ruby 3 fix: exist? instead of exists? #34

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
22b7bc2
exist? instead of exists?
Kazhuu Mar 17, 2023
bf452c6
change another exists? call to exist?
Kazhuu Mar 20, 2023
b44f38b
Merge branch 'master' into ruby3-fix
AdityaHirapara Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/browserstack/localbinary.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def initialize
end

def download(dest_parent_dir)
unless File.exists? dest_parent_dir
unless File.exist? dest_parent_dir
Dir.mkdir dest_parent_dir
end
uri = URI.parse(@http_path)
Expand Down Expand Up @@ -63,7 +63,7 @@ def binary_path
dest_parent_dir = get_available_dirs
binary_path = File.join(dest_parent_dir, "BrowserStackLocal#{".exe" if @windows}")

if File.exists? binary_path
if File.exist? binary_path
binary_path
else
binary_path = download(dest_parent_dir)
Expand Down