Skip to content

Commit 0379991

Browse files
committed
fix: Using script to load modules in __init__; fixing permission for
mounts
1 parent 7c169f5 commit 0379991

File tree

4 files changed

+24
-16
lines changed

4 files changed

+24
-16
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
from os.path import dirname, basename, isfile, join
2+
import glob
3+
4+
modules = glob.glob(join(dirname(__file__), "*"))
5+
__all__ = [basename(f) for f in modules if not isfile(f)]

Makefile

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,21 @@
11
APP_UID := $(shell id -u)
22

3+
setup_mounts:
4+
@mkdir -p mounts/db
5+
@mkdir -p mounts/logs
6+
@mkdir -p mounts/modules
7+
@chown $(APP_UID) mounts/db
8+
@chown $(APP_UID) mounts/logs
9+
@chown $(APP_UID) mounts/modules
10+
311
## make all : Run service, test and linter
412
.PHONY: all
513
all: build test lint
614

715
## make dev : Build and start docker containers - (web/test/db)
816
.PHONY: dev
917
dev: export APPUID = $(APP_UID)
10-
dev:
18+
dev: setup_mounts
1119
@docker-compose build && docker-compose up -d web celery
1220

1321
## make build : Build and start docker containers - (web and db)
@@ -26,7 +34,7 @@ logs:
2634

2735
## Run tests with coverage
2836
.PHONY: test
29-
test:
37+
test: setup_mounts
3038
@if [ $$(docker ps -a -f name=dev | wc -l) -eq 2 ]; then \
3139
docker exec dev python -m pytest --version; \
3240
else \

docker-compose.yml

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,9 @@ services:
1212
- ./secrets/ops_app_dev.env
1313
volumes:
1414
- ./:/srv/code/dev
15-
- access_modules:/srv/code/dev/Access/access_modules
16-
- database_store:/srv/code/dev/db
17-
- logs_volume:/ebs/logs
15+
- ./mounts/modules:/srv/code/dev/Access/access_modules
16+
- ./mounts/db:/srv/code/dev/db
17+
- ./mounts/logs:/ebs/logs
1818
ports:
1919
- 8000:8000
2020
depends_on:
@@ -30,7 +30,7 @@ services:
3030
env_file:
3131
- ./secrets/ops_mysql_dev.env
3232
volumes:
33-
- database_store:/var/lib/mysql
33+
- ./mounts/db:/var/lib/mysql
3434
redis:
3535
container_name: redis
3636
image: redis:alpine
@@ -46,9 +46,9 @@ services:
4646
args:
4747
APPUID: "${APPUID}"
4848
volumes:
49-
- access_modules_celery:/srv/code/dev/Access/access_modules
50-
- database_store:/srv/code/dev/db
51-
- logs_volume:/ebs/logs
49+
- ./mounts/modules:/srv/code/dev/Access/access_modules
50+
- ./mounts/db:/srv/code/dev/db
51+
- ./mounts/logs:/ebs/logs
5252
env_file:
5353
- ./secrets/ops_app_celery.env
5454
depends_on:
@@ -69,9 +69,4 @@ services:
6969
- ./secrets/ops_app_test.env
7070
volumes:
7171
- .:/srv/code/dev
72-
- logs_volume:/ebs/logs
73-
volumes:
74-
access_modules:
75-
access_modules_celery:
76-
database_store:
77-
logs_volume:
72+
- ./mounts/logs:/ebs/logs

scripts/clone_access_modules.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
shutil.rmtree("Access/access_modules/%s" % each_access_module)
1717
except Exception as e:
1818
print("Got Error while deleting the path %s" % str(e))
19-
open('Access/access_modules/__init__.py', 'w').close()
19+
shutil.copyfile('Access/base_email_access/access_modules_init.py', "Access/access_modules/__init__.py")
2020

2121
requirements_file = 'Access/access_modules/requirements.txt'
2222
if not os.path.exists(requirements_file):

0 commit comments

Comments
 (0)