Remove any protocol part from --proxy-host #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchougule
reviewed
Aug 19, 2020
rchougule
reviewed
Aug 19, 2020
rchougule
reviewed
Aug 19, 2020
rchougule
suggested changes
Aug 19, 2020
Contributor
rchougule
left a comment
rchougule
left a comment
There was a problem hiding this comment.
minor changes and unit tests addition...
rchougule
reviewed
Aug 20, 2020
rchougule
reviewed
Aug 20, 2020
rchougule
reviewed
Aug 20, 2020
francisf
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Task: https://browserstack.atlassian.net/browse/ACE-1059
Remove any protocol (http / https) part from proxy host since Node's HTTP module doesn't handle it on its own while making any request. Thus, for any proxy which is not resolvable via DNS, it will fail if the input is of the format:
http://host:port.