Upgrade dependencies #317
Upgrade dependencies #317
Conversation
ericbeland
left a comment
ericbeland
left a comment
There was a problem hiding this comment.
Looks ok except for my hesitation around the windows changes to gradlew. They might also be fine, but before I sign off, I want to understand the rationale.
|
|
||
| goto fail | ||
|
|
||
| :init |
There was a problem hiding this comment.
Have these changes been tested on Windows? I don't have a Windows machine handy. Can you provide a rationale for the gradlew.bat changes so I can understand better why we should remove this?
There was a problem hiding this comment.
Hi.
This file is automatically updated when you run command
./gradlew wrapper --gradle-version=6.7.1 --distribution-type=bin
It's the official recommended way to upgrade gradle.
No, I personally haven't tried to run this file on Windows, but I don't see any reasons why it should not work.
There was a problem hiding this comment.
Perfect, thanks for the explanation!
|
@ericbeland I have resolved conflicts and rebased the branch on latest |
|
I'm ready to merge this, but can we pull out the minor bump on awaitility in this PR? We have a PR here #270 generated by dependabot that does the awaitility bump, and that minor bump keeps failing to build (3 times), so I was planning to revisit that later. |
|
@ericbeland Sorry, I don't understand what you are asking for.
|
browserup-proxy-core/build.gradle
Outdated
| implementation 'javax.xml.bind:jaxb-api:2.3.1' | ||
|
|
||
| implementation 'org.awaitility:awaitility:4.0.2' | ||
| implementation 'org.awaitility:awaitility:4.0.3' |
There was a problem hiding this comment.
When dependabot generated a PR for awaitiity 4.0.3, I could not for the life of me get the build tests to pass. I closed it out. I haven't done a dive into why our tests consistently failed, but until I do, I would be nervous to merge a PR with 4.0.3 in it.
2 participants
No description provided.