This repository was archived by the owner on Jun 11, 2024. It is now read-only.
Initial Pre-Release Cleanup #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epic-alex-rodionov
approved these changes
Apr 24, 2019
…lease-cleanup # Conflicts: # README.md # browserup-proxy-core/src/main/java/com/browserup/bup/filters/HarCaptureFilter.java # build.gradle
dpowell
suggested changes
Apr 24, 2019
browserup-proxy-core/src/main/java/com/browserup/bup/filters/HarCaptureFilter.java
Outdated
Show resolved
Hide resolved
dpowell
force-pushed
the
pre-release-cleanup
branch
from
cb5a877 to
05e8796
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started reviewing the code for release. These are some initial issues I found. I also added a changelog, and some references to the legacy browsermob proxy implementation which we won't be supporting.