PythonScript_1.3.0.0_x64.msi chooses "Program Files (x86)" for install

[zenis0102]

really awesome plugin and thanks for the new release but x64 msi installer picks Program Files (x86) instead of Program Files for installation

[chcg]

Caused by https://github.com/bruderstein/PythonScript/blob/master/installer/PythonScript.wxs#L27 as ProgramFilesFolder defaults to 32bit, see https://docs.microsoft.com/de-de/windows/desktop/Msi/property-reference#system_folder_properties

64bit is ProgramFiles64Folder (The full path to the predefined 64-bit Program Files folder.)

See
https://stackoverflow.com/questions/6231950/using-wix-to-create-32bit-and-64bit-installers-from-one-wxs-file

Additionally:
https://stackoverflow.com/questions/43386704/program-files-folder-instead-of-program-files-x86-installation-path-in-wix
and
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/64-Bit-program-files-folder-td5948080.html

[vsrawat]

64bit is ProgramFiles64Folder There is no such folder. 32 bit should go to c:\Program Files (x86)\notepad+ folder 64 bit should go to c:\Program Files\notepad+ folder Another bug is, it is not extracting PythonScript.dll and Python27.dll from msi for some strange reason. I had noticed and changed the folder to 64 bit location when msi run, even then it has not extracted PythonScript.dll and Python27.dll I had to manually extract from msi and put to respective location. Thanks. -- Rawat

…

On 2/4/2019 10:26 PM, chcg wrote: Caused by https://github.com/bruderstein/PythonScript/blob/master/installer/PythonScript.wxs#L27 as ProgramFilesFolder defaults to 32bit, see https://docs.microsoft.com/de-de/windows/desktop/Msi/property-reference#system_folder_properties 64bit is ProgramFiles64Folder — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AISGl_RmWZLuiPzbY9T_IzJqSQtQ16Ceks5vKGZLgaJpZM4abNlL>.

[chcg]

@vsrawat Probably a sideeffect of the wrong parameters on msi creation and therefore the access rights to store executable code from a 32bit installer to the 64bit program files folder is prohibited by windows.
I think I tested the installer with a portable version of N++ at some unrestricted folder location and that installation isn't facing this restriction.

[vsrawat]

oh, and last time, I installed through notepad++ plugin Admin (or Manager, I don't remeber), and that had installed in correct folder. Actually, most of the users install it through plugin manager, and it got installed correctly, that is why the problem of Oct release didn't even surface till now, 4 months later. Thanks. -- Rawat

…

On 2/5/2019 1:28 AM, chcg wrote: @vsrawat <https://github.com/vsrawat> Probably a sideeffect of the wrong parameters on msi creation and therefore the access rights to store executable code from a 32bit installer to the 64bit program files folder is prohibited by windows. I think I tested the installer with a portable version of N++ at some unrestricted folder location and that installation isn't facing this restriction. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#118 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AISGlxBHPBU7QOdHrYHtfsE72Z4a-reXks5vKJDzgaJpZM4abNlL>.

[zenis0102]

I wasn't sure that I should add this as another New Issue or just add a comment here!

But seem like PythonScript_1.3.0.0_x64 is not compatible with the latest Notepad++ (as of today Feb-6th-2019 the latest x64 version is npp.7.6.3.Installer.x64.exe) anymore due to the change of the way NPP installs and loads plugins.

I've done all following and still not been able to make it work with NPP:

1. Installed PythonScript_1.3.0.0_x64 through original installer but as I mentioned at my first post it goes to Program Files (x86) ant not to Program Files

2. Through installer I tried to manually change the installation path but the new path was NOT updated in installer and still it points to Program Files (x86) and even installs to Program Files (x86) either

3. I installed it as usual then tried to move installed files to NPP folder (python27.dll in root directory of NPP and the rest into plugins directory) but it didn't worked because lately NPP has decided to put plugins dll and its associated files in their own specific folders (i.e. AnyPlugin.dll and associated files into AnyPlugin folder), refer to the 3th paragraph here Notepad++ 7.6.3 released

   Due to the security reason, from this version Notepad++ will load plugins only from <NPP_INST_DIR>\plugins. In the case of installer, Notepad++ is installed in %ProgramFiles%\Notepad++\ - plugins are loaded from %ProgramFiles%\Notepad++\plugins\ instead of %ProgramData%\Notepad++\plugins\ in the previous version. This change has no impact on current loading behaviour of portable version. Sorry for the inconvenience regarding this change - I believe there's no more modification concerning the plugins location in the future.

4. I created PythonScript folder inside NPP plugins folder and moved PythonScript.dll and the other associated files and folders there but still ,to no avail, even moved python27.dll inside that folder and it didn't worked again

5. I created another PythonScript folder inside previously-created PythonScript folder like C:\Program Files\Notepad++\plugins\PythonScript\PythonScript and moved python27.dll into plugins\PythonScript and the dll and the rest to plugins\PythonScript\PythonScript but again didn't worked

6. I did all in steps 4 and 5 in %USERPROFILE%\AppData\Roaming\Notepad++ and %USERPROFILE%\AppData\Local\Notepad++ but again no success

And finally I tried to find and install PythonScript from Notepad++ Plugin Admin as @vsrawat offered but PythonScript plugin does not exist in Notepad++ Plugin Admin list anymore or maybe at least for me!

sorry for the long comment :(

[chcg]

There is already an issue for it #109. Currently this plugin is not adapted to N++ 7.6.x plugin changes and therefore it is not part of Notepad++ Plugin Admin list.

[chcg]

See wixtoolset/issues#2165 and wixtoolset/issues#5908. Tried to use
<?define PlatformProgramFilesFolder = "ProgramFiles64Folder" ?>

for x64, but that doesn't help.

Seems adding - arch as candle parameter and some wxs settings did it make work now.