Problem with using ampersand in notepad.prompt() prompt text

[sasumner]

When using an ampersand ( & ) in the "prompt" argument to notepad.prompt() it gets "distorted" in a way that Windows programmers will easily understand. :-)

Examples:

notepad.prompt('Tom & Jerry', '', '')
produces:

notepad.prompt('Tom&Jerry', '', '')
produces:

The example directly above SHOULD produce the following:

Pythonscript 1.5.2.0

[chcg]

Reproducible up to release 3.0.4 .
Further chars are also broken, e.g.:

notepad.prompt('ß!"§$%&/()=?´`öä#ü+ÖÄÜ*', 'ß!"§$%&/()=?´`öä#ü+ÖÄÜ*', '')

Additionally there is an issue with transformation of non ASCII input to Unicode.

See https://github.com/bruderstein/PythonScript/blob/master/PythonScript/src/NotepadPlusWrapper.cpp#L723-L725
and
https://github.com/bruderstein/PythonScript/blob/master/PythonScript/src/PromptDialog.cpp#L65-L67
the input strings are just added as ASCII strings to the dialog.

[chcg]

The described issue is caused by:
https://docs.microsoft.com/en-us/windows/win32/dlgbox/dlgbox-programming-considerations#mnemonics
and could be avoided by usage of SS_NOPREFIX:
https://docs.microsoft.com/en-us/windows/win32/controls/static-control-styles
or escaping of & by &&.

[sasumner]

Since there is no real need for "underlined accelerators" in the notepad.prompt() box that I can see, if I were implementing it I would avoid them entirely, possibly using the SS_NOPREFIX thing, although I didn't read about it.

escaping of & by &&.

Well, yes, Windows programmers understand this, but maybe not Python programmers.
And it is how I produced my "SHOULD" screenshot above. :-)

[chcg]

Start of fix, see chcg@9c83bea