Add some .ico or .bmp files in the installation package.

[vsrawat]

I tried to add my script's icon on toolbar, but it goes to Documents folder where there are no .ico .bmp files, and I am not aware where to find those files. So I couldn't add that.

Please consider adding some .ico or .bmp files in the installation package, and clicking on "set icon" in configuration window should go to that specific folder where those ico bmp files are stored in ps installation.

Thanks.

[chcg]

That sounds strange. If you have no own icons, why should you then want to set one?
You could find some examples here:
https://github.com/bruderstein/PythonScript/tree/master/PythonScript/res
They are compiled as resources into the dll. So it doesn't make sense to distributed them additionally.

[vsrawat]

Why should I have my own icons? I never created any. I am not a developer or designer or photoshop-er. I use npp, I installed pythonscript, I wrote my script, I was running that accessing from menu, that required some clicks, so I wanted to add that an icon in the toolbar that can be run with a single click. So, when the software is providing option to add an icon for each script on the toolbar, there should be some easy method to have ready made icons provided bundled with the software. The link you give has no relevant icon that can be added to a script, though folder open/ close can be used as placemarker and only I will know that clicking this icon will not open/ close any folder and would rather run my script. Anyway, if someone can tell me where w8.1 stores its set of icons, I will select one from that, or shall google about that. This is a suggestion as a layman user, and I feel many must be feeling such a requirement, so you can add or decide not to add some icon files in the 11 MB package to save some bytes. Thanks. -- Rawat

…

On 4/3/2021 12:06 AM, chcg wrote: That sounds strange. If you have no own icons, why should you then want to set one? You could find some examples here: https://github.com/bruderstein/PythonScript/tree/master/PythonScript/res They are compiled as resources into the dll. So it doesn't make sense to distributed them additionally. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACCINFZVYU43WSJGQFEMALLTGYFBRANCNFSM42JG3ALQ>.

[chcg]

So you didn't get what the usage section of the docu mean:

To edit the script, just hold Ctrl down and click the script in the Scripts menu.

If you click Configuration, you can assign the script either to a toolbar icon, or to the Python Script menu itself. If you assign a script to the menu, then it will appear immediately, but you will not be able to assign a shortcut to it until next time Notepad++ starts.

If you assign it to a toolbar icon, then it will only appear on the next start of Notepad++.

There will be a default icon in the toolbar, if you don't add your custom one for your script. The icons just appear for the toolbar with standard icons set.

There are multiple source to get icons at the web, e.g.
https://iconarchive.com/show/I-like-buttons-icons-by-mazenl77.html
, but typically you need to transform them into a bmp file with e.g. windows paint (load .png and save again as .bmp)

[Ekopalypse]

Since this is marked as invalid, can it be closed?
Providing additional icons doesn't make sense to me, since one usually chooses a particular icon to remind what a particular script does, and given that it's so easy to create your own icons these days, I think it's appropriate to leave that task to the user.

[chcg]

@Ekopalypse I think there was one issue remaining here. Currently it seems just .bmp icons are working fine but not .ico. I wanted to take a closer look at that also it is not directly the issue.

[Ekopalypse]

@chcg

I'm working on getting .ico files to work as well,

but PythonScript doesn't really have a “utility” code module and the required code needs to be added to ShortcutDlg and ConfigFile which don't share other code modules. Is it ok if it is duplicated in this case? Or should I create a utility.h/cpp and include it into both?

[chcg]

@Ekopalypse Both options are fine for me. In case of code duplication a comment on it would be good.

[alankilborn]

My 2c: Avoid duplication. :-)