[Enhancement] Add "Input History" navigation buttons to Console

[Yaron10]

Currently the only way to navigate through "Input History" is via the Up/Down arrows.

1. New users may not be aware of this functionality.
2. "Mouse-Oriented" users would prefer navigating with the mouse.

How about adding << and >> buttons to the console?
A ComboBox/Drop-down List would be even better.

Thank you.

[sasumner]

I guess it is an OK suggestion...are there other "famous" consoles that have such functionality?

[Yaron10]

What's wrong with being the first?

[sasumner]

Nothing wrong with being a trailblazer. However I think that other consoles don't have this functionality because it isn't necessary; anyone that has used any console understands up and down arrows for command recall after a short period of using their first console. That being said I wouldn't vehemently oppose (hah! not like my opinion means anything!) GUI elements for this as long as the window real-estate was minimal. In other words, for me, if it makes my PS console window have increased vertical size, I don't like it at all. :)

[Yaron10]

Would a History drop-down button be too much?
And if it was placed under the Run button (slightly decreasing its height)?

If you don't like it, I'll retract my request and close this issue.

[sasumner]

@Yaron10 , thanks for your politeness but I am just offering up what I think. If someone considers implementing this I would think they read all of this and consider all opinions (I think that is the point of being able to comment). So in no way do I think you should retract your request. :)

[Yaron10]

@sasumner,

Your politeness is appreciated too.

Here is another option taking the "real estate" into consideration: make "Run" a split-button displaying history on pressing its arrow.
And >>> can be replaced with >. So you might end up with more "real estate". :)

[Yaron10]

A simpler and easier to implement solution would be processing WM_MOUSEWHEEL: wheel up/down should cycle through history just like arrows up/down.

Replacing the EditBox with a ComboBox would be better but slightly more complex to implement.

NPP has a generic addText2Combo() in FindReplaceDlg.cpp.

void addText2Combo(const TCHAR * txt2add, HWND hCombo)
{
	if (!hCombo) return;
	if (!lstrcmp(txt2add, TEXT(""))) return;

	auto i = ::SendMessage(hCombo, CB_FINDSTRINGEXACT, static_cast<WPARAM>(-1), reinterpret_cast<LPARAM>(txt2add));
	if (i != CB_ERR) // found
	{
		::SendMessage(hCombo, CB_DELETESTRING, i, 0);
	}

	i = ::SendMessage(hCombo, CB_INSERTSTRING, 0, reinterpret_cast<LPARAM>(txt2add));
	::SendMessage(hCombo, CB_SETCURSEL, i, 0);
};

Claudia, Scott,
What do you think?

---

Why should the input field be cleared after "Run"? - I often want to run the same string again.
If you want to allow the user type a new string, keep the previous one and select it.

[sasumner]

@Yaron10 you certainly provided some real-estate-free options (mouse-wheel, drop-down combobox). Neither would bother me, but remember, I think the current up/down arrow key thing like on every other console in existence is the ultimate for this type of thing.

I can't agree with the input field retaining its value but selected...just too annoying visually...and really unnecessary (when an up-arrow press recalls it). But....I certainly wouldn't complain if others like the idea.

[Yaron10]

Hello Scott,

Thanks for replying. I appreciate it.

I thought you might oppose a ComboBox. I'm glad you don't. :)

I think the current up/down arrow key thing like on every other console in existence is the ultimate for this type of thing.

You could still use the arrows with a ComboBox. Why force "mouse-oriented-users" use the keyboard?

I can't agree with the input field retaining its value but selected...just too annoying visually...and really unnecessary (when an up-arrow press recalls it). But....I certainly wouldn't complain if others like the idea.

OK. Let's wait for @ClaudiaFrank's opinion.

[sasumner]

Why force "mouse-oriented-users" use the keyboard?

Ah ha! It's finally been said explicitly! :) The base nature of the >>> prompt is that you use the keyboard at it. Given that, going to the mouse for anything related to this is unnatural, when the up/down arrow keys are so accessible (you're already at the keyboard). Note that I'm not a keyboard purist at all (I like the mouse...for useful mousey things,,,). But again, I'm not going to complain, unless someone wants to take away my up/down arrow capability here (and I'm not worried at all that they do).

[Yaron10]

I agree that most of the time you should use the keyboard. But often - for short tests - I find it much more convenient to use the mouse.

Sure, no change without your explicit approval. :)

@Yaron10
I'm a keyboard junkie - so I don't really care about mouse functionality and Scott knows this :-)
Which way of drop down functionality you are looking for.
Something like in the find dialog or just two buttons (up/down) like you normally have when you
want to increase/decrase numerical values?

Something like this?

[Yaron10]

Hello Claudia,

Thank you for replying and for the kind willingness to implement it. :) Much appreciated.

A ComboBox like the one used in the find dialog would be much better.
Scott would prefer not to retain the value after pressing "Run".
Can you make that configurable?

I don't find it necessary, but would you like to add an option to clear history?
::SendDlgItemMessage(hWnd, ID, CB_RESETCONTENT, 0, 0);

---

What are the Download/Upload icons?

Yaron, once we know how it should look like an additional if statement to check if it should be retained
or not is easy to implement.

Q: The edit control is at the bottom so opening a combo box should always open upwards and the most recent entry should be next to the edit control, so going from bottom to top in
combo box list means getting older and older entries, right?

What are the Download/Upload icons?

see #15
Just a test to see if it works.

[Yaron10]

once we know how it should look like an additional if statement to check if it should be retained
or not is easy to implement.

Great. 👍

The edit control is at the bottom so opening a combo box should always open upwards

If the combo contains two/three items it might open downwards.
If NPP is not maximized, the combo may contain many more items and still open downwards.
So IMO the expected behavior is always having the recent item at the top.

Many thanks.

---

see #15
Just a test to see if it works.

Thanks and best of luck.