-
-
Notifications
You must be signed in to change notification settings - Fork 2
[Tests] Normalize subtree test names and reuse message constant #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves test code maintainability by normalizing test function names and eliminating code duplication in subtree tests.
- Added a shared constant
expectedSizeFourMessageto replace repeated "expected size to be 4" assertion messages - Renamed test functions to follow Go naming conventions by removing underscores
- Replaced all hardcoded error message strings with the new constant
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|


What Changed
subtree_test.go.Why It Was Necessary
goconstwarning around repeated literals and simplifies future updates.Testing Performed
go test ./...golangci-lint run(fails in this environment because the configured lintersarangolint,embeddedstructfieldcheck, andwsl_v5are not recognized by the installed golangci-lint build)Impact / Risk
https://chatgpt.com/codex/tasks/task_e_68e8488070648321bc47c770e6794d68