Skip to content

Conversation

@mrz1836
Copy link
Collaborator

@mrz1836 mrz1836 commented Oct 10, 2025

What Changed

  • Introduced a shared powerOfTwoMessage constant in power_of_two_test.go so each assertion references the same format string.

Why It Was Necessary

  • Removes repeated literals that triggered a maintainability warning and keeps the assertion output consistent.

Testing Performed

  • /root/.local/share/mise/installs/go/1.24.3/bin/golangci-lint run --config=.golangci.json
  • go test ./...

Impact / Risk

  • Low risk – this is a small refactor limited to test assertions.

Assignee: @mrz1836


https://chatgpt.com/codex/tasks/task_e_68e84841478c8321a8ac59aa39e8491f

Copilot AI review requested due to automatic review settings October 10, 2025 00:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a shared constant for power-of-two assertion messages to eliminate code duplication and improve maintainability in test code.

  • Adds a powerOfTwoMessage constant to deduplicate repeated string literals
  • Replaces inline assertion messages with the shared constant across three test functions
  • Addresses maintainability warnings by removing code duplication

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added the size/XS Very small change (≤10 lines) label Oct 10, 2025
@github-actions github-actions bot added the feature Any new significant addition label Oct 10, 2025
@sonarqubecloud
Copy link

@mrz1836 mrz1836 merged commit 0e803da into master Oct 10, 2025
38 checks passed
@github-actions github-actions bot deleted the feat/fix-issue-and-run-linter branch October 10, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex feature Any new significant addition size/XS Very small change (≤10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants