Skip to content

Conversation

@mrz1836
Copy link
Collaborator

@mrz1836 mrz1836 commented Oct 10, 2025

What Changed

  • Renamed the subtree benchmark helpers to follow Go's benchmark naming convention without underscores.

Why It Was Necessary

  • Existing benchmark names violated linting rules that enforce Go's benchmark naming regex, generating maintainability warnings.

Testing Performed

  • golangci-lint run (fails: binary built with Go 1.23 while module targets Go 1.24.3 in this environment)
  • go test ./...

Impact / Risk

  • Low risk: benchmark names only, no functional logic touched.
  • Restores compliance with naming lint checks for benchmark functions.

https://chatgpt.com/codex/tasks/task_e_68e848597c10832193af9e76674a9d6d

Copilot AI review requested due to automatic review settings October 10, 2025 00:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames Go benchmark function identifiers to comply with Go's benchmark naming conventions by removing underscores from function names.

  • Renamed three benchmark functions to follow Go naming standards
  • Removed underscores from benchmark function names to satisfy linting requirements
  • Ensures compliance with Go's benchmark naming regex patterns

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions github-actions bot added size/XS Very small change (≤10 lines) feature Any new significant addition labels Oct 10, 2025
@sonarqubecloud
Copy link

@mrz1836 mrz1836 merged commit 7e95d84 into master Oct 10, 2025
38 checks passed
@github-actions github-actions bot deleted the feat/fix-issue-and-run-linter-mi3jyi branch October 10, 2025 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex feature Any new significant addition size/XS Very small change (≤10 lines)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants